Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(177)

Issue 6843076: code review 6843076: net: fix data race on fd.sysfd (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by dfc
Modified:
11 years, 4 months ago
Reviewers:
CC:
dvyukov, bradfitz, golang-dev
Visibility:
Public.

Description

net: fix data race on fd.sysfd Fixes issue 4369. Remove the check for fd.sysfd < 0, the first line of fd.accept() tests if the fd is open correctly and will handle the fd being closed during accept.

Patch Set 1 #

Patch Set 2 : diff -r bbc0024af4a4 https://code.google.com/p/go #

Patch Set 3 : diff -r bbc0024af4a4 https://code.google.com/p/go #

Patch Set 4 : diff -r bbc0024af4a4 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/net/tcpsock_posix.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
dfc
Hello dvyukov@google.com, bradfitz@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 4 months ago (2012-11-18 10:33:18 UTC) #1
dvyukov
LGTM
11 years, 4 months ago (2012-11-18 10:53:11 UTC) #2
bradfitz
LGTM btw, please remove "brad_danga_com" from the reviewer line and use "bradfitz" in the future. ...
11 years, 4 months ago (2012-11-18 17:05:12 UTC) #3
dfc
11 years, 4 months ago (2012-11-18 19:54:20 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=852ee39cc8c4 ***

net: fix data race on fd.sysfd

Fixes issue 4369.

Remove the check for fd.sysfd < 0, the first line of fd.accept() tests if the fd
is open correctly and will handle the fd being closed during accept.

R=dvyukov, bradfitz
CC=golang-dev
http://codereview.appspot.com/6843076
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b