Issue 6843061: code review 6843061: runtime/cgo: fix compilation on Windows with CFLAGS -Wa...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6843061: code review 6843061: runtime/cgo: fix compilation on Windows with CFLAGS -Wa... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by minux1

Modified:
11 years, 5 months ago

Reviewers:

CC:
golang-dev, brainman

Visibility:
Public.

Description

runtime/cgo: fix compilation on Windows with CFLAGS -Wall -Werror also fix one out-of-date comment in cmd/ld/pe.c as well.

Patch Set 1 #

Patch Set 2 : diff -r 591fc8a0131a https://code.google.com/p/go #

Patch Set 3 : diff -r 591fc8a0131a https://code.google.com/p/go #

Patch Set 4 : diff -r a26a8ada8f6e https://code.google.com/p/go/ #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
M	src/cmd/ld/pe.c	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/cgo/gcc_windows_386.c	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/runtime/cgo/gcc_windows_amd64.c	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 5 months ago (2012-11-15 11:03:19 UTC) #1

brainman

Oops! Thank you. Should you add "Fixes Issue 4379"? LGTM Alex

11 years, 5 months ago (2012-11-16 00:20:32 UTC) #2

brainman

On 2012/11/16 00:20:32, brainman wrote: > > Should you add "Fixes Issue 4379"? > Never ...

11 years, 5 months ago (2012-11-16 00:55:45 UTC) #3

minux1

11 years, 5 months ago (2012-11-17 18:06:46 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=5eee09217fcd ***

runtime/cgo: fix compilation on Windows with CFLAGS -Wall -Werror
also fix one out-of-date comment in cmd/ld/pe.c as well.

R=golang-dev, alex.brainman
CC=golang-dev
http://codereview.appspot.com/6843061

Expand All Messages | Collapse All Messages