code review 6842066: net/http/cgi: more windows perl test work

net/http/cgi: more windows perl test work

Don't rely on finding cmd.exe in a particular spot.

Fixes issue 4401

[bradfitz, 2012-11-19 17:24:44]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[mkrautz, 2012-11-19 17:38:26]

getcwd() on my Perl install returns a path that looks like "c:/users/...". That
is, drive letter and no backslashes.

[mkrautz, 2012-11-19 17:38:46]

https://codereview.appspot.com/6842066/diff/4001/src/pkg/net/http/cgi/testdat...
File src/pkg/net/http/cgi/testdata/test.cgi (right):

https://codereview.appspot.com/6842066/diff/4001/src/pkg/net/http/cgi/testdat...
src/pkg/net/http/cgi/testdata/test.cgi:60: }
Adding the following snippet

} elsif ($dir =~ "^[a-zA-Z]:/") {
    $dir =~ s!/!\\!g;
}

makes it work on my installation.

[bradfitz, 2012-11-19 18:21:30]

Hello golang-dev@googlegroups.com, krautz@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[mkrautz, 2012-11-19 18:33:39]

LGTM with the fixes below. But my Perl-fu is not too strong. :)

Since this fixes the issue, s/Update/Fixes/ in the description.

https://codereview.appspot.com/6842066/diff/11001/src/pkg/net/http/cgi/testda...
File src/pkg/net/http/cgi/testdata/test.cgi (right):

https://codereview.appspot.com/6842066/diff/11001/src/pkg/net/http/cgi/testda...
src/pkg/net/http/cgi/testdata/test.cgi:22: print "from $dir\n";
Debug print?

https://codereview.appspot.com/6842066/diff/11001/src/pkg/net/http/cgi/testda...
src/pkg/net/http/cgi/testdata/test.cgi:24: print " to $dir\n";
Ditto.

https://codereview.appspot.com/6842066/diff/11001/src/pkg/net/http/cgi/testda...
src/pkg/net/http/cgi/testdata/test.cgi:28: print " to $dir\n";
Ditto.

https://codereview.appspot.com/6842066/diff/11001/src/pkg/net/http/cgi/testda...
src/pkg/net/http/cgi/testdata/test.cgi:30: print " to $dir\n";
Ditto.

[bradfitz, 2012-11-19 18:39:21]

Hello golang-dev@googlegroups.com, krautz@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2012-11-19 18:40:20]

*** Submitted as http://code.google.com/p/go/source/detail?r=6a42774d38e5 ***

net/http/cgi: more windows perl test work

Don't rely on finding cmd.exe in a particular spot.

Fixes issue 4401

R=golang-dev, krautz
CC=golang-dev
http://codereview.appspot.com/6842066