Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1090)

Issue 6842063: code review 6842063: runtime: duplicate code for runtime.nanotime to avoid s... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by minux1
Modified:
11 years, 4 months ago
Reviewers:
CC:
remyoudompheng, shiv, random0x00, rsc, golang-dev
Visibility:
Public.

Description

runtime: duplicate code for runtime.nanotime to avoid stack overflow in vDSO clock_gettime Fixes issue 4402.

Patch Set 1 #

Patch Set 2 : diff -r f5b22a4df675 https://code.google.com/p/go #

Patch Set 3 : diff -r f5b22a4df675 https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r bbc0024af4a4 https://code.google.com/p/go/ #

Patch Set 5 : diff -r db11b6a8c8f9 https://code.google.com/p/go #

Total comments: 2

Patch Set 6 : diff -r b26a08dc81f0 https://code.google.com/p/go/ #

Patch Set 7 : diff -r b26a08dc81f0 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -12 lines) Patch
M src/pkg/runtime/sys_linux_amd64.s View 1 2 3 4 5 1 chunk +35 lines, -12 lines 0 comments Download

Messages

Total messages: 12
minux1
Hello remyoudompheng@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 4 months ago (2012-11-18 09:09:26 UTC) #1
remyoudompheng
http://codereview.appspot.com/6842063/diff/1002/src/pkg/runtime/sys_linux_amd64.s File src/pkg/runtime/sys_linux_amd64.s (right): http://codereview.appspot.com/6842063/diff/1002/src/pkg/runtime/sys_linux_amd64.s#newcode150 src/pkg/runtime/sys_linux_amd64.s:150: IMULQ $1000, DX the exit_nt looks a bit hard ...
11 years, 4 months ago (2012-11-18 09:15:16 UTC) #2
minux1
PTAL. On 2012/11/18 09:15:16, remyoudompheng wrote: http://codereview.appspot.com/6842063/diff/1002/src/pkg/runtime/sys_linux_amd64.s#newcode150 > src/pkg/runtime/sys_linux_amd64.s:150: IMULQ $1000, DX > the exit_nt ...
11 years, 4 months ago (2012-11-18 09:20:19 UTC) #3
minux1
gentle ping.
11 years, 4 months ago (2012-11-25 20:39:47 UTC) #4
remyoudompheng
It fixed the issue for me on ArchLinux but I'd like confirmation from the other ...
11 years, 4 months ago (2012-11-25 20:47:00 UTC) #5
remyoudompheng
Do you think it would be possible to define: TEXT runtime·vdso_gettimeofday(SB), 7, $somevalue MOVQ runtime·__vdso_gettimeofday_sym(SB), ...
11 years, 4 months ago (2012-11-25 20:50:03 UTC) #6
minux1
On 2012/11/25 20:47:00, remyoudompheng wrote: > It fixed the issue for me on ArchLinux but ...
11 years, 4 months ago (2012-11-25 21:15:55 UTC) #7
minux1
On Mon, Nov 26, 2012 at 4:50 AM, <remyoudompheng@gmail.com> wrote: > Do you think it ...
11 years, 4 months ago (2012-11-25 21:28:04 UTC) #8
shiv
On 2012/11/25 21:15:55, minux wrote: > +CC gns, random0x00. > > I've updated my kernel ...
11 years, 4 months ago (2012-11-26 05:34:09 UTC) #9
rsc
LGTM but please add the comments This is awful. https://codereview.appspot.com/6842063/diff/11002/src/pkg/runtime/sys_linux_amd64.s File src/pkg/runtime/sys_linux_amd64.s (right): https://codereview.appspot.com/6842063/diff/11002/src/pkg/runtime/sys_linux_amd64.s#newcode105 src/pkg/runtime/sys_linux_amd64.s:105: ...
11 years, 4 months ago (2012-11-26 17:19:42 UTC) #10
rsc
By the way, thank you very much for tracking this down.
11 years, 4 months ago (2012-11-26 17:20:19 UTC) #11
minux1
11 years, 4 months ago (2012-11-26 17:42:13 UTC) #12
*** Submitted as http://code.google.com/p/go/source/detail?r=3ec963539561 ***

runtime: duplicate code for runtime.nanotime to avoid stack overflow in vDSO
clock_gettime
Fixes issue 4402.

R=remyoudompheng, shivakumar.gn, random0x00, rsc
CC=golang-dev
http://codereview.appspot.com/6842063
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b