Issue 6822108: code review 6822108: net: make LocalAddr on multicast UDPConn return a liste...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6822108: code review 6822108: net: make LocalAddr on multicast UDPConn return a liste... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by mikio

Modified:
11 years, 5 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

net: make LocalAddr on multicast UDPConn return a listening address The package go.net/ipv4 allows to exist a single UDP listener that join multiple different group addresses. That means that LocalAddr on multicast UDPConn returns a first joined group address is not desirable.

Patch Set 1 : diff -r 422c00e8e022 https://go.googlecode.com/hg/ #

Patch Set 2 : diff -r d465db6441bc https://go.googlecode.com/hg/ #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -14 lines)			Patch
	M	src/pkg/net/multicast_posix_test.go	View	1	1 chunk	+18 lines, -5 lines	0 comments	Download
	M	src/pkg/net/sock_posix.go	View		2 chunks	+10 lines, -9 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 5 months ago (2012-11-12 00:47:03 UTC) #1

mikio

11 years, 5 months ago (2012-11-13 03:27:47 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=0b46d6fe2f1c ***

net: make LocalAddr on multicast UDPConn return a listening address

The package go.net/ipv4 allows to exist a single UDP listener
that join multiple different group addresses. That means that
LocalAddr on multicast UDPConn returns a first joined group
address is not desirable.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6822108

Expand All Messages | Collapse All Messages