Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(252)

Issue 6822066: code review 6822066: net/http: add Cookie fields to satisfy RFC 6265 section 5.3 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by nigeltao
Modified:
11 years, 1 month ago
Reviewers:
rsc, volker.dobler, bradfitz
CC:
golang-dev, r
Visibility:
Public.

Description

net/http: add Cookie fields to satisfy RFC 6265 section 5.3 "Storage Model". Update issue 1960.

Patch Set 1 #

Patch Set 2 : diff -r 5bc48b616305 https://code.google.com/p/go #

Patch Set 3 : diff -r 5bc48b616305 https://code.google.com/p/go #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M src/pkg/net/http/cookie.go View 1 1 chunk +17 lines, -8 lines 3 comments Download

Messages

Total messages: 4
nigeltao
Hello bradfitz@golang.org, dr.volker.dobler@gmail.com (cc: golang-dev@googlegroups.com, r@golang.org, rsc@golang.org), I'd like you to review this change to ...
11 years, 5 months ago (2012-11-01 04:36:06 UTC) #1
volker.dobler
Everything is there to implement a RFC 6265 cookie jar. But Cookie is now a ...
11 years, 5 months ago (2012-11-01 09:02:09 UTC) #2
rsc
LGTM but wait for Brad I agree about the need for additional comments.
11 years, 5 months ago (2012-11-01 17:19:45 UTC) #3
nigeltao
11 years, 1 month ago (2013-02-01 00:53:51 UTC) #4
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b