Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(330)

Issue 6821069: code review 6821069: runtime: use runtime·callers when racefuncenter's pc i... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by remyoudompheng
Modified:
11 years, 4 months ago
Reviewers:
rsc
CC:
golang-dev, rsc
Visibility:
Public.

Description

runtime: use runtime·callers when racefuncenter's pc is on the heap.

Patch Set 1 #

Patch Set 2 : diff -r 9f006a6e4d60 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9f006a6e4d60 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 9f006a6e4d60 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 95ebaa90899e https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/pkg/runtime/race.c View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 5 months ago (2012-11-01 20:10:17 UTC) #1
remyoudompheng
The race report for this example became ugly: func main2() { var a int ch ...
11 years, 5 months ago (2012-11-01 20:12:42 UTC) #2
remyoudompheng
ping
11 years, 4 months ago (2012-11-06 23:21:18 UTC) #3
rsc
LGTM
11 years, 4 months ago (2012-11-07 14:20:41 UTC) #4
remyoudompheng
11 years, 4 months ago (2012-11-07 20:35:27 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=c37ad3c7cb80 ***

runtime: use runtime·callers when racefuncenter's pc is on the heap.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6821069
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b