Issue 6821068: code review 6821068: cmd/gc: instrument blocks for race detection.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6821068: code review 6821068: cmd/gc: instrument blocks for race detection. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by remyoudompheng

Modified:
11 years, 5 months ago

Reviewers:

CC:
golang-dev, rsc, dvyukov

Visibility:
Public.

Description

cmd/gc: instrument blocks for race detection. It happens that blocks are used for function calls in a quite low-level way so they cannot be instrumented as usual. Blocks are also used for inlined functions.

Patch Set 1 #

Patch Set 2 : diff -r 9f006a6e4d60 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 3 : diff -r 311b51675518 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 311b51675518 https://go.googlecode.com/hg/ #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -2 lines)			Patch
	M	src/cmd/gc/racewalk.c	View	1 2	2 chunks	+23 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

remyoudompheng

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 5 months ago (2012-11-01 20:07:30 UTC) #1

dvyukov

LGTM with the comment below. I've added the tests for this case: https://codereview.appspot.com/6525052/diff2/12019:16019/src/pkg/runtime/race/mop_test.go They pass ...

11 years, 5 months ago (2012-11-02 08:09:29 UTC) #3

remyoudompheng

11 years, 5 months ago (2012-11-02 23:11:15 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=f2f1298fc620 ***

cmd/gc: instrument blocks for race detection.

It happens that blocks are used for function calls in a
quite low-level way so they cannot be instrumented as
usual.

Blocks are also used for inlined functions.

R=golang-dev, rsc, dvyukov
CC=golang-dev
http://codereview.appspot.com/6821068

http://codereview.appspot.com/6821068/diff/2001/src/cmd/gc/racewalk.c
File src/cmd/gc/racewalk.c (right):

http://codereview.appspot.com/6821068/diff/2001/src/cmd/gc/racewalk.c#newcode139
src/cmd/gc/racewalk.c:139: racewalklist(n->ninit, nil);
On 2012/11/02 08:09:29, dvyukov wrote:
> It is already handled on line 102.

Done.

Expand All Messages | Collapse All Messages