Issue 6820117: CORS support for go-muxer

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6820117: CORS support for go-muxer

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by alexv

Modified:
13 years ago

Reviewers:
crhym3, proppy

CC:
appengine-code-reviews+go_googlegroups.com

Visibility:
Public.

More Reviews

Description

Something I'm experimenting with. Full source code is here: http://code.google.com/p/go-muxer/

Patch Set 1 #

Total comments: 5

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -2 lines)			Patch
M	README.txt	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	muxer.go	View	4 chunks	+38 lines, -1 line	4 comments	Download
M	muxer_test.go	View	1 chunk	+30 lines, -0 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

crhym3

https://codereview.appspot.com/6820117/diff/1/muxer.go File muxer.go (right): https://codereview.appspot.com/6820117/diff/1/muxer.go#newcode62 muxer.go:62: SetCORS(origin, credentials, headers string) Add a better description of ...

13 years, 1 month ago (2012-11-08 11:16:58 UTC) #2

proppy

13 years ago (2012-11-29 23:27:35 UTC) #3

https://codereview.appspot.com/6820117/diff/1/muxer.go
File muxer.go (right):

https://codereview.appspot.com/6820117/diff/1/muxer.go#newcode42
muxer.go:42: CORS_ALLOW_ORIGIN      = "Access-Control-Allow-Origin"
CorsAllowOrigin

https://codereview.appspot.com/6820117/diff/1/muxer.go#newcode95
muxer.go:95: origin      string
you could consider moving this to a different struct and embedding it.

https://codereview.appspot.com/6820117/diff/1/muxer.go#newcode101
muxer.go:101: func (dm *defaultMux) SetCORS(origin, credentials, headers string)
{
Then you could just construct a struct literal for settings all the field at
once.

Expand All Messages | Collapse All Messages