code review 6819107: runtime: fix instrumentation of slice append for race d...

runtime: fix instrumentation of slice append for race detection

[dvyukov, 2012-11-08 14:08:51]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[iant2, 2012-11-08 16:29:52]

LGTM

On Thu, Nov 8, 2012 at 6:08 AM,  <dvyukov@google.com> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://dvyukov%40google.com@code.google.com/p/go/
>
>
> Description:
> runtime: fix instrumentation of slice append for race detection
>
> Please review this at http://codereview.appspot.com/6819107/
>
> Affected files:
>   M src/pkg/runtime/slice.c
>
>
> Index: src/pkg/runtime/slice.c
> ===================================================================
> --- a/src/pkg/runtime/slice.c
> +++ b/src/pkg/runtime/slice.c
> @@ -86,6 +86,8 @@
>                         runtime·racereadpc(x.array + i*t->elem->size, pc);
>                 for(i=x.len; i<x.cap; i++)
>                         runtime·racewritepc(x.array + i*t->elem->size, pc);
> +               for(i=0; i<y.len; i++)
> +                       runtime·racereadpc(y.array + i*t->elem->size, pc);
>         }
>
>         if(m > x.cap)
>
>

[dvyukov, 2012-11-08 16:37:35]

*** Submitted as http://code.google.com/p/go/source/detail?r=a91f2cb13436 ***

runtime: fix instrumentation of slice append for race detection

R=golang-dev, iant
CC=golang-dev
http://codereview.appspot.com/6819107