Issue 6819106: code review 6819106: cmd/gc: racewalk: fix instrumentation of structs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6819106: code review 6819106: cmd/gc: racewalk: fix instrumentation of structs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by dvyukov

Modified:
11 years, 5 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/gc: racewalk: fix instrumentation of structs + do not instrument go.itab.*

Patch Set 1 #

Patch Set 2 : diff -r b661b713984f https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r e3d1b93bfa09 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r e3d1b93bfa09 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r cbb5a28097e9 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -15 lines)			Patch
	M	src/cmd/gc/racewalk.c	View	1 2	5 chunks	+33 lines, -15 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

11 years, 5 months ago (2012-11-08 14:08:09 UTC) #1

dvyukov

11 years, 5 months ago (2012-11-14 12:27:46 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=df991a1c237f ***

cmd/gc: racewalk: fix instrumentation of structs
+ do not instrument go.itab.*

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6819106

Expand All Messages | Collapse All Messages