Issue 6819082: code review 6819082: sort: fix comment for various Search routines

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6819082: code review 6819082: sort: fix comment for various Search routines (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by minux1

Modified:
11 years, 5 months ago

Reviewers:

CC:
r, 0xjnml, golang-dev

Visibility:
Public.

Description

sort: fix comment for various Search routines Fixes issue 4205 (again).

Patch Set 2 : diff -r 126c37a9e33c https://code.google.com/p/go/ #

Patch Set 3 : diff -r 126c37a9e33c https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r 126c37a9e33c https://code.google.com/p/go/ #

Patch Set 5 : diff -r d2e88aa183da https://code.google.com/p/go/ #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	src/pkg/sort/search.go	View	1 2 3	4 chunks	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

minux1

Hello r@golang.org (cc: 0xjnml@gmail.com, golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 5 months ago (2012-11-03 11:42:12 UTC) #1

0xjnml

https://codereview.appspot.com/6819082/diff/8001/src/pkg/sort/search.go File src/pkg/sort/search.go (right): https://codereview.appspot.com/6819082/diff/8001/src/pkg/sort/search.go#newcode97 src/pkg/sort/search.go:97: // as specified by Search. The return value is ...

11 years, 5 months ago (2012-11-03 12:10:02 UTC) #2

minux1

11 years, 5 months ago (2012-11-06 21:07:57 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=418e35ac7dc7 ***

sort: fix comment for various Search routines
Fixes issue 4205 (again).

R=r, 0xjnml
CC=golang-dev
http://codereview.appspot.com/6819082

Expand All Messages | Collapse All Messages