Checking if Transforms are hidden

[david.burns, 2012-11-05 23:28:15]

Checking if Transforms are hidden - Now cross browser

[andreastt2, 2012-11-06 11:54:13]

http://codereview.appspot.com/6816090/diff/2001/dom.js
File dom.js (right):

http://codereview.appspot.com/6816090/diff/2001/dom.js#newcode857
dom.js:857: +    var transform = bot.dom.getEffectiveStyle(e, 'transform') ||
Should getting the effective style of "transform" come last?  If the browser
supports that, I think it should trump the vendor-specific CSS prefixes.

http://codereview.appspot.com/6816090/diff/2001/dom.js#newcode864
dom.js:864: +    if (transform && transform !== "none") {
You can save one level of indentation by doing

  if (transform && transform == "none") {
    return true;
  }

  …

here.

http://codereview.appspot.com/6816090/diff/2001/dom.js#newcode865
dom.js:865: +      var getTransformValues = function (matrix){
space before curly brace?

http://codereview.appspot.com/6816090/diff/2001/dom.js#newcode867
dom.js:867: +        // matrix(0.866025, 0.5, -0.5, 0.866025, 0px, 0px)
It *might*.  I think you can leave some of these values out.  Isn't there a
Closure way to deal with the parsing of CSS parameter values?

[david.burns, 2012-11-06 14:10:18]

Updated after feedback and fix of recursive lookup

[JimEvans, 2012-11-06 14:23:50]

Code reviewed. See if my comments are valid.

http://codereview.appspot.com/6816090/diff/6001/javascript/atoms/dom.js
File javascript/atoms/dom.js (right):

http://codereview.appspot.com/6816090/diff/6001/javascript/atoms/dom.js#newco...
javascript/atoms/dom.js:864: debugger;
Did you mean to leave this line uncommented?

http://codereview.appspot.com/6816090/diff/6001/javascript/atoms/dom.js#newco...
javascript/atoms/dom.js:877: if (!(transform.x >= 0 && transform.y >= 0)){
Couldn't transform.x or transform.y be of the form '0px'? If so, will this
strict numeric comparison work?