code review 6815075: go.talks/present: separate parser from present tool

go.talks/present: separate parser from present tool

This will allow present files to be used by the tour and other tools.
This change is the first of a series. It focuses on moving the code
with a minimum of exported changes. I will refine the exported
interface of the present package in a followup change.

[adg, 2012-11-13 11:26:18]

Hello r@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.talks

[r, 2012-11-13 15:24:54]

Curious: why?

[adg, 2012-11-13 15:30:54]

I want to use the parser and action code from the tour, the blog, and other
programs.


On 13 November 2012 16:24, Rob Pike <r@golang.org> wrote:

> Curious: why?
>

[r, 2012-11-13 15:35:15]

That's just the sort of information that belongs in the CL description.

-rob

[adg, 2012-11-13 15:43:47]

I updated the CL description.


On 13 November 2012 16:35, Rob Pike <r@golang.org> wrote:

> That's just the sort of information that belongs in the CL description.
>
> -rob
>

[francesc, 2012-11-14 02:06:42]

https://codereview.appspot.com/6815075/diff/10001/present/dir.go
File present/dir.go (right):

https://codereview.appspot.com/6815075/diff/10001/present/dir.go#newcode52
present/dir.go:52: // extensions maps the presentable file extensions to the
name of the
dir.go makes me think about directories.
I'm not sure this code belongs here.

https://codereview.appspot.com/6815075/diff/10001/present/doc.go
File present/doc.go (left):

https://codereview.appspot.com/6815075/diff/10001/present/doc.go#oldcode21
present/doc.go:21: 
Where did all this documentation go?

[adg, 2012-11-14 08:50:44]

On 14 Nov 2012 03:06, <campoy@golang.org> wrote:
>
>
> https://codereview.appspot.com/6815075/diff/10001/present/dir.go
> File present/dir.go (right):
>
> https://codereview.appspot.com/6815075/diff/10001/present/dir.go#newcode52
> present/dir.go:52: // extensions maps the presentable file extensions to
> the name of the
> dir.go makes me think about directories.
> I'm not sure this code belongs here.

dir.go is concerned with the file system. Could rename it but I don't see a
compelling reason.

> https://codereview.appspot.com/6815075/diff/10001/present/doc.go
> File present/doc.go (left):
>
> https://codereview.appspot.com/6815075/diff/10001/present/doc.go#oldcode21
> present/doc.go:21:
> Where did all this documentation go?

To pkg/present/doc.go

> https://codereview.appspot.com/6815075/

[r, 2012-11-14 14:30:53]

there needs to be command documentation that points to the package
documentation, if that's where you want the formatting information to
be held.

-rob

[r, 2012-11-14 19:28:29]

http://codereview.appspot.com/6815075/diff/10001/present/doc.go
File present/doc.go (right):

http://codereview.appspot.com/6815075/diff/10001/present/doc.go#newcode20
present/doc.go:20: appcfg.py update -A your-app-id -V your-app-version
/path/to/go.talks
you must provide a link here to the file format documentation

[adg, 2012-11-15 19:02:48]

Hello r@golang.org, campoy@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2012-11-15 21:35:30]

LGTM

[adg, 2012-11-15 22:02:04]

*** Submitted as
http://code.google.com/p/go/source/detail?r=4dc5255056df&repo=talks ***

go.talks/present: separate parser from present tool

This will allow present files to be used by the tour and other tools.
This change is the first of a series. It focuses on moving the code
with a minimum of exported changes. I will refine the exported
interface of the present package in a followup change.

R=r, campoy
CC=golang-dev
http://codereview.appspot.com/6815075