Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2063)

Issue 6812091: code review 6812091: runtime: mark race instrumentation callbacks as nosplitstack (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by dvyukov
Modified:
11 years, 4 months ago
Reviewers:
CC:
golang-dev, iant2
Visibility:
Public.

Description

runtime: mark race instrumentation callbacks as nosplitstack It speedups the race detector somewhat, but also prevents getcallerpc() from obtaining lessstack().

Patch Set 1 #

Patch Set 2 : diff -r 10993a316040 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 10993a316040 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 10993a316040 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/pkg/runtime/race.c View 1 4 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
11 years, 4 months ago (2012-11-06 16:35:20 UTC) #1
iant2
LGTM On Tue, Nov 6, 2012 at 8:35 AM, <dvyukov@google.com> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
11 years, 4 months ago (2012-11-06 16:52:54 UTC) #2
dvyukov
11 years, 4 months ago (2012-11-06 16:55:09 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=9fd632db8de2 ***

runtime: mark race instrumentation callbacks as nosplitstack
It speedups the race detector somewhat, but also prevents
getcallerpc() from obtaining lessstack().

R=golang-dev, iant
CC=golang-dev
http://codereview.appspot.com/6812091
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b