Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(30)

Issue 6811060: Add alias in Spanish for espanol note names language

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by pacovila
Modified:
11 years, 5 months ago
Reviewers:
janek
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Add alias in Spanish for espanol note names language

Patch Set 1 #

Patch Set 2 : New implementation allowing more aliases. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M scm/define-note-names.scm View 1 1 chunk +9 lines, -0 lines 2 comments Download

Messages

Total messages: 10
janek
Ah, so \language "español" will do the same as \language "espanol"? That's nice.
11 years, 5 months ago (2012-11-02 08:34:02 UTC) #1
pacovila
Yes, it adds a copy without deactivating the original. El 02/11/2012 09:34, <janek.lilypond@gmail.com> escribió: > ...
11 years, 5 months ago (2012-11-02 08:39:11 UTC) #2
pacovila
http://codereview.appspot.com/6811060/diff/4001/scm/define-note-names.scm File scm/define-note-names.scm (right): http://codereview.appspot.com/6811060/diff/4001/scm/define-note-names.scm#newcode961 scm/define-note-names.scm:961: ;; add two native utf-8 alisases. Pairs obey cp-like ...
11 years, 5 months ago (2012-11-06 18:18:52 UTC) #3
pacovila
https://codereview.appspot.com/6811060/diff/4001/scm/define-note-names.scm File scm/define-note-names.scm (right): https://codereview.appspot.com/6811060/diff/4001/scm/define-note-names.scm#newcode964 scm/define-note-names.scm:964: (append language-pitch-names I will use two-spaces indenting here. Emacs ...
11 years, 5 months ago (2012-11-07 15:57:58 UTC) #4
pacovila
Hello. Am I countdowned or rather needsworked? Thanks.
11 years, 5 months ago (2012-11-12 08:40:28 UTC) #5
janek
On Mon, Nov 12, 2012 at 9:40 AM, <paconet.org@gmail.com> wrote: > Hello. Am I countdowned ...
11 years, 5 months ago (2012-11-12 18:54:11 UTC) #6
pacovila
2012/11/12 Janek Warchoł <janek.lilypond@gmail.com>: > On Mon, Nov 12, 2012 at 9:40 AM, <paconet.org@gmail.com> wrote: ...
11 years, 5 months ago (2012-11-12 19:07:35 UTC) #7
janek
On Mon, Nov 12, 2012 at 8:07 PM, Francisco Vila <paconet.org@gmail.com> wrote: > 2012/11/12 Janek ...
11 years, 5 months ago (2012-11-12 19:14:34 UTC) #8
pacovila
2012/11/12 Janek Warchoł <janek.lilypond@gmail.com>: > On Mon, Nov 12, 2012 at 8:07 PM, Francisco Vila ...
11 years, 5 months ago (2012-11-12 19:29:49 UTC) #9
janek
11 years, 5 months ago (2012-11-12 19:32:06 UTC) #10
On Mon, Nov 12, 2012 at 8:29 PM, Francisco Vila <paconet.org@gmail.com> wrote:
> 2012/11/12 Janek Warchoł <janek.lilypond@gmail.com>:
>> Well, both of them say "Reported by project member paconet.org".
>> I think git-cl tricked you.  Probably the second issue was created
>> when you uploaded second patch set; i suppose you didn't specify the
>> tracker issue number and a new one was created instead of updating
>> existing one.
>
> I remember git-cl created the rietveld code-reviewing issue and I
> created the googlecode tracking issue by hand. Is the google code
> tracking issue created automatically as well?

yes, unless you're using a very outdated git-cl.

jaenk
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b