Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1132)

Issue 681041: Cleanup: sort header order, use explicit std:: prefix rather than using std; (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 2 months ago by hanwenn
Modified:
13 years, 3 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Cleanup: sort header order, use explicit std:: prefix rather than using std; Remove from header too. Remove Font_metric::index_to_ascii. Remove Font_metric::get_indexed_char_stencil() Rename Font_metric::get_indexed_char() to Font_metric::get_indexed_char_dimensions(). Remove Font_metric::get_ascii_char() and descendents. Be const correct in Open_type_font::index_to_charcode() Remove ly:get-glyph and supporting infrastructure. Cleanup: remove Simple_font_metric, Font_metric::text_dimension Add Output_def argument to Font_metric::text_stencil(). Side effects: - remove fontify-text, fontify-white-text - remove ly:text-dimension - remove output-ps.scm (text ) output expression. Cleanup and document scale-layout; mark cloned layout by setting 'clone = #t. Remove unused indirection function Font_metric::text_stencil and derived versions. indent fix.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -232 lines) Patch
M lily/book.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/font-metric.cc View 5 chunks +7 lines, -49 lines 0 comments Download
M lily/font-metric-scheme.cc View 2 chunks +0 lines, -38 lines 0 comments Download
M lily/include/font-metric.hh View 3 chunks +7 lines, -25 lines 0 comments Download
M lily/include/modified-font-metric.hh View 2 chunks +2 lines, -6 lines 0 comments Download
M lily/include/open-type-font.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/pango-font.hh View 1 chunk +2 lines, -2 lines 0 comments Download
M lily/modified-font-metric.cc View 3 chunks +6 lines, -40 lines 0 comments Download
M lily/note-head.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/open-type-font.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M lily/pango-font.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M lily/system-start-delimiter.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/text-interface.cc View 1 chunk +2 lines, -4 lines 0 comments Download
scm/output-ps.scm View 1 chunk +0 lines, -23 lines 0 comments Download
scm/paper.scm View 1 chunk +12 lines, -14 lines 0 comments Download
scm/safe-lily.scm View 2 chunks +0 lines, -2 lines 0 comments Download
scm/stencil.scm View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 3
hanwenn
Hi guys, this is a general cleanup of Font_metric related code. there are some backward ...
14 years, 2 months ago (2010-03-21 18:23:16 UTC) #1
wl_gnu.org
> this is a general cleanup of Font_metric related code. Looks good. > there are ...
14 years, 1 month ago (2010-03-22 06:24:52 UTC) #2
hanwenn
14 years, 1 month ago (2010-03-22 12:58:50 UTC) #3
On Mon, Mar 22, 2010 at 3:24 AM, Werner LEMBERG <wl@gnu.org> wrote:
>> there are some backward incompatible changes (removal of SCM
>> functions), but I believe it should be safe, because the functions
>> were not useful, little used anyway.
>
> In case someone has been using them, are there workarounds to
> reestablish the functionality?

Good question; I am not sure if there are any sensible uses anyway.
(ly:get-glyph uses get_ascii_char which is not really appropriate for
either pango fonts or the music fonts).

-- 
Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b