Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(638)

Issue 6810087: Allow music of nominally zero duration to be typeset. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by dak
Modified:
11 years, 4 months ago
Reviewers:
benko.pal
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Allow music of nominally zero duration to be typeset. This is important for things like incipits without notes or other material that produces output without spending time. In particular, this is interesting for \score in markup which more often than not only contains few notational elements and where attempts to just get basic key/clef/timesignature drawings are sometimes failing in frustrating manners.

Patch Set 1 #

Patch Set 2 : Fix segfaults etc for 0 systems. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -15 lines) Patch
M lily/constrained-breaking.cc View 2 chunks +9 lines, -5 lines 0 comments Download
M lily/global-context-scheme.cc View 1 chunk +1 line, -2 lines 0 comments Download
M lily/optimal-page-breaking.cc View 1 2 chunks +12 lines, -5 lines 0 comments Download
M lily/page-spacing.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M lily/simple-spacer.cc View 1 chunk +6 lines, -3 lines 1 comment Download

Messages

Total messages: 4
benko.pal
LGTM in the sense that it won't make things worse; I've tried to understand the ...
11 years, 4 months ago (2012-11-16 22:13:59 UTC) #1
dak
On 2012/11/16 22:13:59, benko.pal wrote: > LGTM in the sense that it won't make things ...
11 years, 4 months ago (2012-11-16 22:57:29 UTC) #2
dak
Reinhold Kainhofer <reinhold@fam.tuwien.ac.at> writes: > On 2012-11-16 23:57, dak@gnu.org wrote: >> I have not actually ...
11 years, 4 months ago (2012-11-17 07:38:42 UTC) #3
benko.pal
11 years, 4 months ago (2012-11-17 11:05:12 UTC) #4
On 2012/11/16 22:57:29, dak wrote:
> On 2012/11/16 22:13:59, benko.pal wrote:
> > LGTM in the sense that it won't make things worse; I've tried to understand
> > the code but failed, see below.
> 
> I have not actually tried to understand the code.  I just added checks for
> existing array elements before access until I could no longer make LilyPond
> segfault or produce programming errors.
> 
> So this is, indeed, strictly a patch on the "won't make things worse" basis,
> except for the one, initial removal of a zero-duration check, necessary for
sane
> behavior in things like incipits without notes.

yes, the commit message made me guess so; I hoped someone (Joe?) would chime in.

L still GTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b