Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10499)

Issue 6800043: code review 6800043: cmd/gc: inlining functions with local variables (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by lvd
Modified:
11 years, 5 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

cmd/gc: inlining functions with local variables - make sure dclcontext == PAUTO only in function bodies - introduce PDISCARD to discard declarations in bodies of repeated imports - skip printing initializing OAS'es in export mode, assuming they only occur after ODCL's - remove ODCL and the initializing OAS from inl.c:ishairy - fix confused use of ->typecheck in typecheckinl: it's about the ->inl, not about the fn. - debuging aids: print ntype on ONAMEs too and -Emm instead of -Ell. fixes issue 2812

Patch Set 1 #

Patch Set 2 : diff -r cb628b55af72 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r cb628b55af72 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r cb628b55af72 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 7df8438a2c41 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -158 lines) Patch
M src/cmd/gc/dcl.c View 1 2 chunks +4 lines, -1 line 0 comments Download
M src/cmd/gc/fmt.c View 1 2 chunks +10 lines, -0 lines 0 comments Download
M src/cmd/gc/go.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/gc/go.y View 1 3 chunks +7 lines, -3 lines 0 comments Download
M src/cmd/gc/inl.c View 1 5 chunks +12 lines, -21 lines 0 comments Download
M src/cmd/gc/y.tab.c View 1 45 chunks +137 lines, -133 lines 0 comments Download

Messages

Total messages: 3
lvd
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 5 months ago (2012-10-26 16:30:04 UTC) #1
rsc
LGTM in the cl desc s/:/ / in the fixes issue line
11 years, 5 months ago (2012-10-29 12:43:19 UTC) #2
lvd
11 years, 5 months ago (2012-10-29 12:55:31 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=bb4ee132b967 ***

cmd/gc: inlining functions with local variables

- make sure dclcontext == PAUTO only in function bodies
- introduce PDISCARD to discard declarations in bodies of repeated imports
- skip printing initializing OAS'es in export mode, assuming they only occur
after ODCL's
- remove ODCL and the initializing OAS from inl.c:ishairy
- fix confused use of ->typecheck in typecheckinl: it's about the ->inl, not
about the fn.
- debuging aids: print ntype on ONAMEs too and -Emm instead of -Ell.

fixes issue 2812

R=rsc
CC=golang-dev
http://codereview.appspot.com/6800043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b