Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5885)

Issue 6784063: Change \alterBroken interface to match that of other tweak/overrides (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by dak
Modified:
11 years, 6 months ago
Reviewers:
david.nalesnik
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Change \alterBroken interface to match that of other tweak/overrides I am not really fabulously happy about this particular syntax change, but it makes alter-broken more versatile (and let's face it, this likely needs to get used at least as often once rather than as a general override) and lets it match the API of the other tweak/override-like functions. Suggestions for improvements welcome. check-grob-path is stolen from another issue that is still under review. Here are the containing commits: Change input/regression/alter-broken.ly to include tweak-like usage Rerun scripts/auxiliar/update-with-convert-ly.sh Because the version did not change, this required a git revert -n of the last such run beforehand. Change \alterBroken interface to match that of other tweak/overrides Implement function check-grob-path for checking/extending grob path specs From the function documentation string: Check a grob path specification @var{path}, a symbol list (or a single symbol), for validity and possibly complete it. Returns the completed specification, or @code{#f} if invalid. If optional @var{parser} is given, a syntax error is raised in that case, optionally using @var{location}. If an optional keyword argument @code{#:start @var{start}} is given, the parsing starts at the given index in the sequence @samp{Context.Grob.property.sub-property...}, with the default of @samp{0} implying the full path. If there is no valid first element of @var{path} fitting at the given path location, an optionally given @code{#:default @var{default}} is used as the respective element instead without checking it for validity at this position. The resulting path after possibly prepending @var{default} can be constrained in length by optional arguments @code{#:min @var{min}} and @code{#:max @var{max}}, defaulting to @samp{1} and unlimited, respectively.

Patch Set 1 #

Patch Set 2 : input/regression/alter-broken.ly: Use \once\alterBroken on Tie, a typical single-use case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -34 lines) Patch
M input/regression/alter-broken.ly View 1 1 chunk +18 lines, -16 lines 0 comments Download
M ly/music-functions-init.ly View 1 chunk +32 lines, -18 lines 0 comments Download
M python/convertrules.py View 1 chunk +2 lines, -0 lines 0 comments Download
M scm/music-functions.scm View 1 chunk +76 lines, -0 lines 0 comments Download

Messages

Total messages: 1
david.nalesnik
11 years, 6 months ago (2012-10-29 00:15:42 UTC) #1
LGTM!

Thanks very much for doing this, David.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b