Issue 6761057: Bake's code review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6761057: Bake's code review

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by danielcamara

Modified:
12 years, 6 months ago

Reviewers:
Alex Afanasyev

CC:
ns-3-reviews_googlegroups.com

Visibility:
Public.

More Reviews

Patch Set 2 : Bake's code review #

Total comments: 3

Patch Set 3 : Alex suggestions - Bake Review #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -6 lines)			Patch
M	bake/Bake.py	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	bake/ModuleSource.py	View	1 2	3 chunks	+22 lines, -5 lines	0 comments	Download
M	test/TestModuleSource.py	View	1 2	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Alex Afanasyev

http://codereview.appspot.com/6761057/diff/2001/bake/ModuleSource.py File bake/ModuleSource.py (right): http://codereview.appspot.com/6761057/diff/2001/bake/ModuleSource.py#newcode206 bake/ModuleSource.py:206: ] Not sure if anybody yet uses it, but ...

12 years, 6 months ago (2012-10-25 15:41:16 UTC) #1

danielcamara

12 years, 6 months ago (2012-11-05 11:12:31 UTC) #2

On 2012/10/25 15:41:16, Alex Afanasyev wrote:
> http://codereview.appspot.com/6761057/diff/2001/bake/ModuleSource.py
> File bake/ModuleSource.py (right):
> 
>
http://codereview.appspot.com/6761057/diff/2001/bake/ModuleSource.py#newcode206
> bake/ModuleSource.py:206: ]
> Not sure if anybody yet uses it, but there are a couple of other compression
> formats that are used by some developers and may be useful to include here. 
On
> top of my head is xz.
  
 Ok, I am adding the options for .xz and .tar.xz, if you have any other that you
think is useful, let me know. 

> 
>
http://codereview.appspot.com/6761057/diff/2001/bake/ModuleSource.py#newcode330
> bake/ModuleSource.py:330: 
> This can be extended to MacOS with macports (port command), as it is the
easiest
> way to install all NS-3 dependencies (including ones for the visualizer) on
OSX.

 Great, thanks for the suggestion! I am not exactly a proficient MAC user, but
as far as I understood from the macports help page, it will not be hard to add
it to Bake.  I will do it, but I will not release until I manage to test it
properly.   

> 
>
http://codereview.appspot.com/6761057/diff/2001/bake/ModuleSource.py#newcode658
> bake/ModuleSource.py:658: 
> I think "checkout" command here is totally wrong.  It should be "merge".
> 

 You are right. I will change it! 

> First of all, if it is an intended behavior, then name "update" is really
> misleading, because instead of updating the code, it is doing re-checkout. 
> Second of all, I think for mercurial and bzr, you do pull, which equivalent to
> fetch&&merge in git (I'm not 100% sure).

Expand All Messages | Collapse All Messages