Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10794)

Issue 6761045: Doc: Pitches.itely @knownissue OctavateEight grob (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by pkx166h
Modified:
11 years, 6 months ago
Reviewers:
janek, Trevor Daniels
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Doc: Pitches.itely @knownissue OctavateEight grob Issue 2832 Shows that any integers attached to a Clef is treated as a separate Grob so any override applied to the Clef also has to be applied as a separate override to the OctavateEight grob. Includes brief description and @lilypond example.

Patch Set 1 #

Patch Set 2 : Change transparent to color for better clarity #

Patch Set 3 : Change transparent to color for better clarity #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M Documentation/notation/pitches.itely View 1 1 chunk +15 lines, -0 lines 2 comments Download

Messages

Total messages: 6
Trevor Daniels
LGTM, but just a thought - might it be better to override the colour so ...
11 years, 6 months ago (2012-10-24 14:57:28 UTC) #1
pkx166h
On 2012/10/24 14:57:28, Trevor Daniels wrote: > LGTM, but just a thought - might it ...
11 years, 6 months ago (2012-10-24 15:18:26 UTC) #2
janek
one nitpick, otherwise LGTM http://codereview.appspot.com/6761045/diff/6001/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): http://codereview.appspot.com/6761045/diff/6001/Documentation/notation/pitches.itely#newcode1183 Documentation/notation/pitches.itely:1183: Any integers that are attached ...
11 years, 6 months ago (2012-10-28 16:32:57 UTC) #3
pkx166h
Thanks Janek, done and pushed with your syntax change. http://codereview.appspot.com/6761045/diff/6001/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): http://codereview.appspot.com/6761045/diff/6001/Documentation/notation/pitches.itely#newcode1183 Documentation/notation/pitches.itely:1183: ...
11 years, 6 months ago (2012-10-29 08:06:52 UTC) #4
pkx166h
authorJames Lowe <pkx166h@gmail.com> Wed, 24 Oct 2012 12:51:38 +0000 (13:51 +0100) committerJames Lowe <pkx166h@gmail.com> Mon, ...
11 years, 6 months ago (2012-10-29 08:21:22 UTC) #5
janek
11 years, 6 months ago (2012-11-01 08:45:05 UTC) #6
On 2012/10/29 08:06:52, J_lowe wrote:
> Thanks Janek, done and pushed with your syntax change.

thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b