Issue 6759052: code review 6759052: reflect: stop thinking that MaxFloat32 overflows float32.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6759052: code review 6759052: reflect: stop thinking that MaxFloat32 overflows float32. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by remyoudompheng

Modified:
11 years, 5 months ago

Reviewers:

CC:
golang-dev, minux1, rsc

Visibility:
Public.

Description

reflect: stop thinking that MaxFloat32 overflows float32. Fixes issue 4282.

Patch Set 1 #

Patch Set 2 : diff -r 8d919bfe75d3 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8d919bfe75d3 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 8d919bfe75d3 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r a88b24459ad8 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r a88b24459ad8 https://go.googlecode.com/hg/ #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -1 line)			Patch
	M	src/pkg/reflect/all_test.go	View	1 2 3	1 chunk	+39 lines, -0 lines	0 comments	Download
	M	src/pkg/reflect/value.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

remyoudompheng

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 5 months ago (2012-10-25 06:55:03 UTC) #1

remyoudompheng

Hello golang-dev@googlegroups.com, minux.ma@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 5 months ago (2012-10-25 21:16:44 UTC) #4

rsc

LGTM This is probably ever so slightly different than what strconv allows (up to 1/2 ...

11 years, 5 months ago (2012-10-25 21:18:43 UTC) #5

remyoudompheng

11 years, 5 months ago (2012-10-26 06:39:51 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=ee334ccad623 ***

reflect: stop thinking that MaxFloat32 overflows float32.

Fixes issue 4282.

R=golang-dev, minux.ma, rsc
CC=golang-dev
http://codereview.appspot.com/6759052

Expand All Messages | Collapse All Messages