Issue 6741051: code review 6741051: cmd/go: invoke gcc -print-libgcc-file-name only once

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6741051: code review 6741051: cmd/go: invoke gcc -print-libgcc-file-name only once (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by minux1

Modified:
11 years, 5 months ago

Reviewers:
dvyukov

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/go: invoke gcc -print-libgcc-file-name only once

Patch Set 2 : diff -r caf040d030f3 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 8a65cc8e918e https://code.google.com/p/go/ #

Patch Set 4 : diff -r 418e35ac7dc7 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 418e35ac7dc7 https://code.google.com/p/go/ #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -5 lines)			Patch
	M	src/cmd/go/build.go	View	1 2 3	2 chunks	+10 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 5 months ago (2012-11-02 18:27:00 UTC) #1

minux1

*** Submitted as http://code.google.com/p/go/source/detail?r=85af2ea57953 *** cmd/go: invoke gcc -print-libgcc-file-name only once R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6741051

11 years, 5 months ago (2012-11-06 21:10:07 UTC) #3

dvyukov

11 years, 5 months ago (2012-11-23 09:46:43 UTC) #4

On 2012/11/06 21:10:07, minux wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=85af2ea57953 ***
> 
> cmd/go: invoke gcc -print-libgcc-file-name only once
> 
> R=golang-dev, rsc
> CC=golang-dev
> http://codereview.appspot.com/6741051



Hello, guys

WARNING: DATA RACE
Write by goroutine 20:
  main.(*builder).cgo()
      /usr/local/google/home/dvyukov/go1/src/cmd/go/build.go:1639 +0x317b
  main.(*builder).build()
      /usr/local/google/home/dvyukov/go1/src/cmd/go/build.go:688 +0xbdd
  main.func·004()
      /usr/local/google/home/dvyukov/go1/src/cmd/go/build.go:570 +0x4bd
  main.func·005()
      /usr/local/google/home/dvyukov/go1/src/cmd/go/build.go:619 +0x122

Previous write by goroutine 18:
  main.(*builder).cgo()
      /usr/local/google/home/dvyukov/go1/src/cmd/go/build.go:1639 +0x317b
  main.(*builder).build()
      /usr/local/google/home/dvyukov/go1/src/cmd/go/build.go:688 +0xbdd
  main.func·004()
      /usr/local/google/home/dvyukov/go1/src/cmd/go/build.go:570 +0x4bd
  main.func·005()
      /usr/local/google/home/dvyukov/go1/src/cmd/go/build.go:619 +0x122

Goroutine 20 (running) created at:
  main.(*builder).do()
      /usr/local/google/home/dvyukov/go1/src/cmd/go/build.go:621 +0x679
  main.runTest()
      /usr/local/google/home/dvyukov/go1/src/cmd/go/test.go:385 +0x27ff
  main.main()
      /usr/local/google/home/dvyukov/go1/src/cmd/go/main.go:148 +0x786
  runtime.main()
      /usr/local/google/home/dvyukov/go1/src/pkg/runtime/proc.c:248 +0x91

Goroutine 18 (running) created at:
  main.(*builder).do()
      /usr/local/google/home/dvyukov/go1/src/cmd/go/build.go:621 +0x679
  main.runTest()
      /usr/local/google/home/dvyukov/go1/src/cmd/go/test.go:385 +0x27ff
  main.main()
      /usr/local/google/home/dvyukov/go1/src/cmd/go/main.go:148 +0x786
  runtime.main()
      /usr/local/google/home/dvyukov/go1/src/pkg/runtime/proc.c:248 +0x91


It's not detected on builder, because go calls exit syscall, so race detector
does not have chance to override it.

Repro:

$ go install -race cmd/go
$ go test -race -run=none -short -bench=none std

may be required to run several times with bumped GOMAXPROCS.

Expand All Messages | Collapse All Messages