Issue 6739051: code review 6739051: exp/locale/collate: slightly changed collation elements:

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6739051: code review 6739051: exp/locale/collate: slightly changed collation elements: (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by mpvl

Modified:
11 years, 6 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

exp/locale/collate: slightly changed collation elements: - Allow secondary values below the default value in second form. This is to support before tags for secondary values, as used by Chinese. - Eliminate collation elements that are guaranteed to be immaterial after a weight increment.

Patch Set 1 #

Patch Set 2 : diff -r 7c53f5b1e1bf https://go.googlecode.com/hg #

Patch Set 3 : diff -r 7c53f5b1e1bf https://go.googlecode.com/hg #

Patch Set 4 : diff -r 7c53f5b1e1bf https://go.googlecode.com/hg #

Patch Set 5 : diff -r 7c53f5b1e1bf https://go.googlecode.com/hg #

Total comments: 2

Patch Set 6 : diff -r b685816af832 https://go.googlecode.com/hg #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -24 lines)			Patch
M	src/pkg/exp/locale/collate/build/colelem.go	View	1 2 3 4 5	2 chunks	+23 lines, -13 lines	0 comments	Download
M	src/pkg/exp/locale/collate/build/colelem_test.go	View	1 2 3 4	4 chunks	+15 lines, -9 lines	0 comments	Download
M	src/pkg/exp/locale/collate/colelem.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/exp/locale/collate/colelem_test.go	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mpvl

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

11 years, 6 months ago (2012-10-22 12:39:23 UTC) #1

LGTM https://codereview.appspot.com/6739051/diff/6007/src/pkg/exp/locale/collate/build/colelem.go File src/pkg/exp/locale/collate/build/colelem.go (right): https://codereview.appspot.com/6739051/diff/6007/src/pkg/exp/locale/collate/build/colelem.go#newcode266 src/pkg/exp/locale/collate/build/colelem.go:266: next := append([][]int(nil), make([]int, len(elems[0]))) isn't this just ...

11 years, 6 months ago (2012-10-22 19:10:11 UTC) #2

mpvl

11 years, 6 months ago (2012-10-25 11:02:37 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=b1403cc90f4f ***

exp/locale/collate: slightly changed collation elements:
- Allow secondary values below the default value in second form. This is
  to support before tags for secondary values, as used by Chinese.
- Eliminate collation elements that are guaranteed to be immaterial
  after a weight increment.

R=r
CC=golang-dev
http://codereview.appspot.com/6739051

http://codereview.appspot.com/6739051/diff/6007/src/pkg/exp/locale/collate/bu...
File src/pkg/exp/locale/collate/build/colelem.go (right):

http://codereview.appspot.com/6739051/diff/6007/src/pkg/exp/locale/collate/bu...
src/pkg/exp/locale/collate/build/colelem.go:266: next := append([][]int(nil),
make([]int, len(elems[0])))
On 2012/10/22 19:10:11, r wrote:
> isn't this just
> next := [][]int{make([]int, len(elems[0]))}

Done.

Expand All Messages | Collapse All Messages