Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(271)

Issue 6736068: code review 6736068: cmd/6g: fix crash in cgen_bmul. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by remyoudompheng
Modified:
11 years, 5 months ago
Reviewers:
CC:
nigeltao, rsc, golang-dev
Visibility:
Public.

Description

cmd/6g: fix crash in cgen_bmul. Used to print: ../test/torture.go:116: internal compiler error: bad width: 0463 (../test/torture.go:116) MOVB ,BX (0, 8)

Patch Set 1 #

Patch Set 2 : diff -r 8d919bfe75d3 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8d919bfe75d3 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 88c4bdf6cfb8 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r b1403cc90f4f https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -12 lines) Patch
M src/cmd/6g/ggen.c View 1 2 3 2 chunks +17 lines, -12 lines 0 comments Download
M test/torture.go View 1 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 11
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 5 months ago (2012-10-22 23:03:34 UTC) #1
nigeltao
Does the codegen change for something less torturous, like: var w, x, y, z byte ...
11 years, 5 months ago (2012-10-23 07:55:23 UTC) #2
remyoudompheng
On 2012/10/23 07:55:23, nigeltao wrote: > Does the codegen change for something less torturous, like: ...
11 years, 5 months ago (2012-10-23 20:49:40 UTC) #3
remyoudompheng
Hello golang-dev@googlegroups.com, nigeltao@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 5 months ago (2012-10-23 22:17:30 UTC) #4
remyoudompheng
Fixing things was too hard. cgen simply doesn't expect operands of different types. Or well, ...
11 years, 5 months ago (2012-10-23 22:28:52 UTC) #5
nigeltao
LGTM.
11 years, 5 months ago (2012-10-24 12:04:09 UTC) #6
rsc
Does the latest CL still use MOVB? That's very expensive.
11 years, 5 months ago (2012-10-24 19:12:33 UTC) #7
remyoudompheng
It doesn't, but that's because it is eliminated at peephole-time. Here is where we stand: ...
11 years, 5 months ago (2012-10-24 19:59:07 UTC) #8
remyoudompheng
Some users are annoyed by the bug. May I submit with Nigel's LGTM and since ...
11 years, 5 months ago (2012-10-25 20:56:48 UTC) #9
rsc
On 2012/10/25 20:56:48, remyoudompheng wrote: > Some users are annoyed by the bug. May I ...
11 years, 5 months ago (2012-10-25 21:43:33 UTC) #10
remyoudompheng
11 years, 5 months ago (2012-10-25 22:29:52 UTC) #11
*** Submitted as http://code.google.com/p/go/source/detail?r=d81bcf447d65 ***

cmd/6g: fix crash in cgen_bmul.

Used to print:
../test/torture.go:116: internal compiler error: bad width: 0463
(../test/torture.go:116) MOVB    ,BX (0, 8)

R=nigeltao, rsc
CC=golang-dev
http://codereview.appspot.com/6736068
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b