Issue 6727047: code review 6727047: go.talks/present: address missed review comments

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6727047: code review 6727047: go.talks/present: address missed review comments (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by adg

Modified:
11 years, 6 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

go.talks/present: address missed review comments

Patch Set 2 : diff -r 965aebfbb749 https://code.google.com/p/go.talks #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	present/doc.go	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	present/parse.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.talks

11 years, 6 months ago (2012-10-17 04:49:49 UTC) #1

LGTM http://codereview.appspot.com/6727047/diff/1/present/parse.go File present/parse.go (right): http://codereview.appspot.com/6727047/diff/1/present/parse.go#newcode35 present/parse.go:35: // optional template function that is available inside ...

11 years, 6 months ago (2012-10-17 04:50:53 UTC) #2

adg

11 years, 6 months ago (2012-10-17 04:56:21 UTC) #3

*** Submitted as
http://code.google.com/p/go/source/detail?r=5c56e29ab2e8&repo=talks ***

go.talks/present: address missed review comments

R=r
CC=golang-dev
http://codereview.appspot.com/6727047

http://codereview.appspot.com/6727047/diff/1/present/parse.go
File present/parse.go (right):

http://codereview.appspot.com/6727047/diff/1/present/parse.go#newcode35
present/parse.go:35: // optional template function that is available inside
templates as name.
On 2012/10/17 04:50:53, r wrote:
> s/as name/under that name/

Done.

Expand All Messages | Collapse All Messages