code review 6725052: go/build: document the behavior of multiple build const...

go/build: document the behavior of multiple build constraints.

[nigeltao, 2012-10-16 23:43:10]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com, pkleiweg@xs4all.nl),

I'd like you to review this change to
https://code.google.com/p/go

[nigeltao, 2012-10-16 23:45:10]

On 17 October 2012 10:43,  <nigeltao@golang.org> wrote:
> go/build: document the behavior of multiple build constraints.
>
> Please review this at http://codereview.appspot.com/6725052/

Russ, if this is a bug, not a feature, then I'm happy to fix the bug instead.

[pebbe, 2012-10-17 09:54:18]

It must be a feature, because it is used in the standard library, in
os/user/lookup_unix.go

[rsc, 2012-10-21 21:01:44]

LGTM

https://codereview.appspot.com/6725052/diff/4002/src/pkg/go/build/doc.go
File src/pkg/go/build/doc.go (right):

https://codereview.appspot.com/6725052/diff/4002/src/pkg/go/build/doc.go#newc...
src/pkg/go/build/doc.go:83: // is equivalent to
Let's focus on the meaning and not on a rewrite:

// corresponds to the boolean formula:
//
//     (linux OR darwin) AND 386

[nigeltao, 2012-10-22 00:15:39]

*** Submitted as http://code.google.com/p/go/source/detail?r=15230435b1de ***

go/build: document the behavior of multiple build constraints.

R=rsc, pkleiweg
CC=golang-dev
http://codereview.appspot.com/6725052