Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(182)

Issue 6724056: code review 6724056: go.crypto/otr: expose IsEncrypted. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by agl1
Modified:
11 years, 6 months ago
Reviewers:
CC:
golang-dev, ioerror
Visibility:
Public.

Description

go.crypto/otr: expose IsEncrypted. It's useful to expose this bit of state because, although callers can keep track of it themselves, it's already in the Conversation so it seems wasteful to make them do so.

Patch Set 1 #

Patch Set 2 : diff -r 29e4e1ec65e5 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 29e4e1ec65e5 https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r 29e4e1ec65e5 https://code.google.com/p/go.crypto #

Patch Set 5 : diff -r 29e4e1ec65e5 https://code.google.com/p/go.crypto #

Patch Set 6 : diff -r 29e4e1ec65e5 https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M otr/otr.go View 1 1 chunk +7 lines, -0 lines 0 comments Download
M otr/otr_test.go View 1 2 3 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3
agl1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto
11 years, 6 months ago (2012-10-17 16:21:26 UTC) #1
ioerror
On 2012/10/17 16:21:26, agl1 wrote: > Hello mailto:golang-dev@googlegroups.com (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...
11 years, 6 months ago (2012-10-17 18:56:46 UTC) #2
agl1
11 years, 6 months ago (2012-10-17 18:58:22 UTC) #3
*** Submitted as
http://code.google.com/p/go/source/detail?r=52776d88cc11&repo=crypto ***

go.crypto/otr: expose IsEncrypted.

It's useful to expose this bit of state because, although callers can
keep track of it themselves, it's already in the Conversation so it
seems wasteful to make them do so.

R=golang-dev, ioerror
CC=golang-dev
http://codereview.appspot.com/6724056
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b