Improved color support

This adds support for the CSS2 color names. It also adds support for hsl() and hsla() from CSS3.

This is based on the patch from John Vivenzio

[erik.arvidsson, 2009-06-07 00:45:49]

I apologize for this taking so long to get done.

[erik.arvidsson, 2009-06-20 03:04:31]

Emil, do you think you can look at this over the weekend?

[eae, 2009-06-22 15:57:59]

http://codereview.appspot.com/67158/diff/1/2
File excanvas.js (right):

http://codereview.appspot.com/67158/diff/1/2#newcode261
Line 261: var colorString =
'aliceblue#F0F8FFantiquewhite#FAEBD7aquamarine#7FFFD4azure#F0FFFFbeige#F5F5DCbisque#FFE4C4black#000000blanchedalmond#FFEBCDblueviolet#8A2BE2brown#A52A2Aburlywood#DEB887cadetblue#5F9EA0chartreuse#7FFF00chocolate#D2691Ecoral#FF7F50cornflowerblue#6495EDcornsilk#FFF8DCcrimson#DC143Ccyan#00FFFFdarkblue#00008Bdarkcyan#008B8Bdarkgoldenrod#B8860Bdarkgray#A9A9A9darkgreen#006400darkgrey#A9A9A9darkkhaki#BDB76Bdarkmagenta#8B008Bdarkolivegreen#556B2Fdarkorange#FF8C00darkorchid#9932CCdarkred#8B0000darksalmon#E9967Adarkseagreen#8FBC8Fdarkslateblue#483D8Bdarkslategray#2F4F4Fdarkslategrey#2F4F4Fdarkturquoise#00CED1darkviolet#9400D3deeppink#FF1493deepskyblue#00BFFFdimgray#696969dimgrey#696969dodgerblue#1E90FFfirebrick#B22222floralwhite#FFFAF0forestgreen#228B22gainsboro#DCDCDCghostwhite#F8F8FFgold#FFD700goldenrod#DAA520grey#808080greenyellow#ADFF2Fhoneydew#F0FFF0hotpink#FF69B4indianred#CD5C5Cindigo#4B0082ivory#FFFFF0khaki#F0E68Clavender#E6E6FAlavenderblush#FFF0F5lawngreen#7CFC00lemonchiffon#FFFACDlightblue#ADD8E6lightcoral#F08080lightcyan#E0FFFFlightgoldenrodyellow#FAFAD2lightgreen#90EE90lightgrey#D3D3D3lightpink#FFB6C1lightsalmon#FFA07Alightseagreen#20B2AAlightskyblue#87CEFAlightslategray#778899lightslategrey#778899lightsteelblue#B0C4DElightyellow#FFFFE0limegreen#32CD32linen#FAF0E6magenta#FF00FFmediumaquamarine#66CDAAmediumblue#0000CDmediumorchid#BA55D3mediumpurple#9370DBmediumseagreen#3CB371mediumslateblue#7B68EEmediumspringgreen#00FA9Amediumturquoise#48D1CCmediumvioletred#C71585midnightblue#191970mintcream#F5FFFAmistyrose#FFE4E1moccasin#FFE4B5navajowhite#FFDEADoldlace#FDF5E6olivedrab#6B8E23orange#FFA500orangered#FF4500orchid#DA70D6palegoldenrod#EEE8AApalegreen#98FB98paleturquoise#AFEEEEpalevioletred#DB7093papayawhip#FFEFD5peachpuff#FFDAB9peru#CD853Fpink#FFC0CBplum#DDA0DDpowderblue#B0E0E6rosybrown#BC8F8Froyalblue#4169E1saddlebrown#8B4513salmon#FA8072sandybrown#F4A460seagreen#2E8B57seashell#FFF5EEsienna#A0522Dskyblue#87CEEBslateblue#6A5ACDslategray#708090slategrey#708090snow#FFFAFAspringgreen#00FF7Fsteelblue#4682B4tan#D2B48Cthistle#D8BFD8tomato#FF6347turquoise#40E0D0violet#EE82EEwheat#F5DEB3whitesmoke#F5F5F5yellowgreen#9ACD32';
I assume you do it this way to reduce the size of the library. Is it really
smaller this way though? 

Initializing it using key value pairs would allow you to get rid of the parse
function below.

var colorData = {
aliceblue:'F0F8FF',
antiquewhite:'FAEBD7',
...

[eae, 2009-06-23 01:46:28]

On 2009/06/23 01:28:45, arv wrote:
> 

Your last update was empty, I bet that wasn't intentional.

[eae, 2009-06-23 01:52:35]

Looks much better, one last comment though.


(btw, patch set 1 seems to have vanished making it harder to do patch to patch
diffs).

http://codereview.appspot.com/67158/diff/3001/4001
File trunk/excanvas.js (right):

http://codereview.appspot.com/67158/diff/3001/4001#newcode261
Line 261: aliceblue: '#F0F8FF',
In the interest of saving a few bytes, how about removing the leading hash
symbol from the color codes?

http://codereview.appspot.com/67158/diff/3001/4001#newcode477
Line 477: str = colorData[styleString] || styleString;
...and then changing this line to read

str = '#' + colorData[styleString] || styleString;

[erik.arvidsson, 2009-06-23 02:24:25]

I think we should either keep it readable or small. If we go for readable, which
I've been convinced, we should then I think it is cleaner to have the values of
the object literal be valid CSS colors.

http://codereview.appspot.com/67158/diff/3001/4001
File trunk/excanvas.js (right):

http://codereview.appspot.com/67158/diff/3001/4001#newcode261
Line 261: aliceblue: '#F0F8FF',
On 2009/06/23 01:52:35, eae wrote:
> In the interest of saving a few bytes, how about removing the leading hash
> symbol from the color codes?

With gzip this will not matter. If we add a string concat every time we want to
get a value it will add two object allocations.

http://codereview.appspot.com/67158/diff/3001/4001#newcode477
Line 477: str = colorData[styleString] || styleString;
On 2009/06/23 01:52:35, eae wrote:
> ...and then changing this line to read
> 
> str = '#' + colorData[styleString] || styleString;

That would be

str = styleString in colorData ? '#' + colorData[styleString] : styleString;

[eae, 2009-06-23 02:49:04]

LGTM

You've got me convinced, let's go for readable.