Issue 67125: radiotap and prism header support

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 67125: radiotap and prism header support (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by Nicola Baldo

Modified:
14 years, 9 months ago

Reviewers:
Mathieu Lacage

CC:
ns-3-reviews_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+530 lines, -51 lines)			Patch
M	examples/mixed-wireless.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	examples/simple-wifi-frame-aggregation.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	examples/third.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	examples/wifi-wired-bridging.cc	View	3 chunks	+6 lines, -3 lines	0 comments	Download
M	src/common/pcap-writer.h	View	3 chunks	+47 lines, -0 lines	1 comment	Download
M	src/common/pcap-writer.cc	View	5 chunks	+312 lines, -0 lines	0 comments	Download
M	src/devices/wifi/wifi-phy.h	View	2 chunks	+60 lines, -18 lines	0 comments	Download
M	src/devices/wifi/wifi-phy.cc	View	2 chunks	+14 lines, -5 lines	0 comments	Download
M	src/devices/wifi/yans-wifi-phy.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/devices/wifi/yans-wifi-phy.cc	View	4 chunks	+9 lines, -7 lines	0 comments	Download
M	src/helper/yans-wifi-helper.h	View	7 chunks	+35 lines, -7 lines	0 comments	Download
M	src/helper/yans-wifi-helper.cc	View	4 chunks	+41 lines, -6 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Mathieu Lacage

14 years, 11 months ago (2009-05-29 12:37:19 UTC) #1

http://codereview.appspot.com/67125/diff/1/7
File src/common/pcap-writer.h (right):

http://codereview.appspot.com/67125/diff/1/7#newcode26
Line 26: #include "ns3/wifi-mode.h"
oops, you should not include wifi headers from src/common because src/common is
supposed to be dependent on src/core and src/simulator only. So, either you move
the relevant wifi headers in src/common or you figure out a way to make this
code not depend on the wifi types.

A simple way to do this would be to replace the preambl argument with a bool and
the mode argument with an integer containing the data rate in mbs.

Expand All Messages | Collapse All Messages