Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(142)

Issue 67048: Refactor to get model and report separately out from JavaTestabilityRunner

Can't Edit
Can't Publish+Mail
Start Review
Created:
17 years, 1 month ago by Shyam
Modified:
11 years, 6 months ago
Reviewers:
Alex
CC:
Karin Lundberg, testability-explorer-dev_googlegroups.com
Base URL:
http://testability-explorer.googlecode.com/svn/trunk/core/
Visibility:
Public.

Description

Refactor JavaTestabilityRunner so that we can keep a handle on the IssuesReporter and not have to be forced to use the ReportPrinterBuilder. Also a lot of renaming.

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -1055 lines) Patch
A src/main/java/com/google/test/metric/AnalysisModel.java View 1 chunk +35 lines, -0 lines 2 comments Download
M src/main/java/com/google/test/metric/JavaTestabilityConfig.java View 4 chunks +4 lines, -4 lines 0 comments Download
M src/main/java/com/google/test/metric/JavaTestabilityRunner.java View 3 chunks +41 lines, -26 lines 1 comment Download
M src/main/java/com/google/test/metric/ReportPrinterBuilder.java View 4 chunks +10 lines, -9 lines 1 comment Download
D src/main/java/com/google/test/metric/report/DrillDownReport.java View 1 chunk +0 lines, -138 lines 0 comments Download
A + src/main/java/com/google/test/metric/report/DrillDownReportGenerator.java View 2 chunks +2 lines, -2 lines 0 comments Download
M src/main/java/com/google/test/metric/report/FreemarkerReportGenerator.java View 1 chunk +1 line, -1 line 0 comments Download
D src/main/java/com/google/test/metric/report/MultiReport.java View 1 chunk +0 lines, -90 lines 0 comments Download
A + src/main/java/com/google/test/metric/report/MultiReportGenerator.java View 4 chunks +15 lines, -15 lines 0 comments Download
D src/main/java/com/google/test/metric/report/PropertiesReport.java View 1 chunk +0 lines, -60 lines 0 comments Download
A + src/main/java/com/google/test/metric/report/PropertiesReportGenerator.java View 2 chunks +2 lines, -2 lines 0 comments Download
D src/main/java/com/google/test/metric/report/Report.java View 1 chunk +0 lines, -32 lines 0 comments Download
A + src/main/java/com/google/test/metric/report/ReportGenerator.java View 2 chunks +1 line, -3 lines 0 comments Download
D src/main/java/com/google/test/metric/report/SourceReport.java View 1 chunk +0 lines, -205 lines 0 comments Download
A + src/main/java/com/google/test/metric/report/SourceReportGenerator.java View 2 chunks +2 lines, -2 lines 0 comments Download
D src/main/java/com/google/test/metric/report/SummaryReport.java View 1 chunk +0 lines, -88 lines 0 comments Download
A + src/main/java/com/google/test/metric/report/SummaryReportModel.java View 3 chunks +3 lines, -2 lines 1 comment Download
D src/main/java/com/google/test/metric/report/TextReport.java View 1 chunk +0 lines, -93 lines 0 comments Download
A + src/main/java/com/google/test/metric/report/TextReportGenerator.java View 1 chunk +3 lines, -3 lines 0 comments Download
D src/main/java/com/google/test/metric/report/XMLReport.java View 1 chunk +0 lines, -121 lines 0 comments Download
M src/main/java/com/google/test/metric/report/XMLReportDiffer.java View 1 chunk +1 line, -1 line 0 comments Download
A + src/main/java/com/google/test/metric/report/XMLReportGenerator.java View 2 chunks +3 lines, -3 lines 0 comments Download
D src/main/java/com/google/test/metric/report/html/HtmlReport.java View 1 chunk +0 lines, -91 lines 0 comments Download
A + src/main/java/com/google/test/metric/report/html/HtmlReportModel.java View 4 chunks +7 lines, -6 lines 0 comments Download
M src/main/java/com/google/test/metric/report/issues/IssuesReporter.java View 3 chunks +7 lines, -7 lines 0 comments Download
M src/test/java/com/google/test/metric/CommandLineConfigTest.java View 4 chunks +11 lines, -11 lines 0 comments Download
M src/test/java/com/google/test/metric/MetricComputerTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M src/test/java/com/google/test/metric/TestabilityRunnerTest.java View 2 chunks +4 lines, -4 lines 0 comments Download
M src/test/java/com/google/test/metric/report/ClassSourceReportTest.java View 1 chunk +1 line, -1 line 0 comments Download
M src/test/java/com/google/test/metric/report/DrillDownReportTest.java View 12 chunks +23 lines, -23 lines 0 comments Download
M src/test/java/com/google/test/metric/report/PropertiesReportTest.java View 1 chunk +1 line, -1 line 0 comments Download
M src/test/java/com/google/test/metric/report/SourceReportTest.java View 1 chunk +1 line, -1 line 0 comments Download
M src/test/java/com/google/test/metric/report/TextReportTest.java View 1 chunk +1 line, -1 line 0 comments Download
M src/test/java/com/google/test/metric/report/XMLReportTest.java View 5 chunks +5 lines, -5 lines 0 comments Download
M src/test/java/com/google/test/metric/report/html/HtmlReportTest.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Shyam
Initial mail for review
17 years, 1 month ago (2009-05-14 18:52:54 UTC) #1
Alex
17 years, 1 month ago (2009-05-14 19:54:13 UTC) #2
LGTM, couple things:

http://codereview.appspot.com/67048/diff/1/35
File src/main/java/com/google/test/metric/AnalysisModel.java (right):

http://codereview.appspot.com/67048/diff/1/35#newcode1
Line 1: 
copyright on all new files

http://codereview.appspot.com/67048/diff/1/35#newcode16
Line 16: 
mention that null is allowed?

http://codereview.appspot.com/67048/diff/1/13
File src/main/java/com/google/test/metric/JavaTestabilityRunner.java (right):

http://codereview.appspot.com/67048/diff/1/13#newcode98
Line 98: e.printStackTrace();
why did the exception handling change?

http://codereview.appspot.com/67048/diff/1/36
File src/main/java/com/google/test/metric/ReportPrinterBuilder.java (right):

http://codereview.appspot.com/67048/diff/1/36#newcode46
Line 46: public class ReportPrinterBuilder {
should probably rename to ReportGeneratorBuilder

http://codereview.appspot.com/67048/diff/1/15
File src/main/java/com/google/test/metric/report/SummaryReportModel.java
(right):

http://codereview.appspot.com/67048/diff/1/15#newcode62
Line 62: @Override
make sure this works with java5 - not an interface method?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b