Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(63)

Issue 6695046: New bar line interface: include whichBar in convert-ly rule for bar line changes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by marc
Modified:
11 years, 6 months ago
Reviewers:
janek
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

This is a follow-up of Issue 2790 and commit cced43289cf170305e6e6517180659a1c4fa91db. The whichBar property is not set explicitly anywhere in the sources and thus was forgotten in the commit above.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M python/convertrules.py View 1 chunk +1 line, -1 line 0 comments Download
M scm/define-context-properties.scm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
janek
Was it not for Graham Percival, to whom i dedicate all my code reviews, i ...
11 years, 6 months ago (2012-10-21 16:46:36 UTC) #1
marc
On 2012/10/21 16:46:36, janek wrote: > Was it not for Graham Percival, to whom i ...
11 years, 6 months ago (2012-10-21 17:25:55 UTC) #2
janek
11 years, 6 months ago (2012-10-21 17:36:40 UTC) #3
Thanks, Marc!

i suggest to abbreviate the committish (first 10 digits should be enough - git
recognizes abbreviated committishes as long as they are unique) - first line of
the commit message should be around 50-60 chars for the sake of nice display in
logs.

best & sorry for nitpicking & LGTM,
Janek
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b