Issue 6688045: Add autogenerated markers to files produced from build scripts.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6688045: Add autogenerated markers to files produced from build scripts. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by Julien Rioux

Modified:
11 years, 6 months ago

Reviewers:
Graham Percival, janek

CC:
lilypond-devel_gnu.org

Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/

Visibility:
Public.

Description

Add autogenerated markers to files produced from build scripts.

Patch Set 1 #

Patch Set 2 : Fix typos and help message from scripts. #

Patch Set 3 : Emit warnings for missing translations. #

Patch Set 4 : Revert last patchset (will submit separetely) #

Patch Set 5 : Fixup bad rebase (sorry, this is it now) #

Patch Set 6 : Fix python KeyError. #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -30 lines)			Patch
M	python/auxiliar/postprocess_html.py	View		3 chunks	+11 lines, -7 lines	0 comments	Download
M	scripts/build/bib2texi.py	View	1 4	3 chunks	+10 lines, -2 lines	0 comments	Download
M	scripts/build/create-version-itexi.py	View		1 chunk	+7 lines, -1 line	0 comments	Download
M	scripts/build/create-weblinks-itexi.py	View	1 3 4	3 chunks	+28 lines, -16 lines	1 comment	Download
M	scripts/build/lys-to-tely.py	View	1 4	3 chunks	+7 lines, -2 lines	0 comments	Download
M	scripts/build/output-distance.py	View	1 2 3 4 5	1 chunk	+3 lines, -0 lines	0 comments	Download
M	scripts/build/website_post.py	View	1 4	3 chunks	+3 lines, -1 line	0 comments	Download
M	scripts/build/www_post.py	View		1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

janek

I haven't noticed anything wrong, but i'm not familiar with this stuff. It would be ...

11 years, 6 months ago (2012-10-15 08:13:01 UTC) #1

Graham Percival

11 years, 6 months ago (2012-10-15 21:25:09 UTC) #2

LGTM

https://codereview.appspot.com/6688045/diff/7009/scripts/build/create-weblink...
File scripts/build/create-weblinks-itexi.py (right):

https://codereview.appspot.com/6688045/diff/7009/scripts/build/create-weblink...
scripts/build/create-weblinks-itexi.py:313: vstring = "v%s.%s" %
tuple(version.split(".", 2)[0:2])
thank you so much for fixing that hard-coding!

Expand All Messages | Collapse All Messages