Issue 6685044: Fix unproper nesting of various property overrides

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6685044: Fix unproper nesting of various property overrides (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by dak

Modified:
11 years, 6 months ago

Reviewers:
janek

CC:
lilypond-devel_gnu.org

Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/

Visibility:
Public.

Description

Fix unproper nesting of various property overrides \acciaccatura and \slashedGrace lose any previous setting of Flag.stroke-style. \crossStaff loses the previous setting of Flag.style \harmonicByFret and \harmonicDots lose the previous setting of TabNoteHead.stencil, NoteHead.Y-extent and NoteHead.stencil This patch depends on issue 2897 which appears likely to end up being dropped as undesired according to the discussion on the developer list. Patch is set to "waiting" and will have to be abandoned if issue 2897 is not accepted.

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	ly/grace-init.ly	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	ly/music-functions-init.ly	View		3 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

janek

11 years, 6 months ago (2012-10-24 10:08:38 UTC) #1

LGTM

can you please change tenses in the commit message?  Every time i see a sentence
like "\acciaccatura and \slashedGrace lose any previous setting of
Flag.stroke-style." i think that it means that *the result of the patch* is that
previous settings are lost.
I think it would be better to write "before this patch, \acciaccatura and
\slashedGrace were losing any previous setting of Flag.stroke-style".

cheers,
Janek

PS as usual, i dedicate my code reviews to Graham Percival. btw, i hope that's
not embarassing for him...

Expand All Messages | Collapse All Messages