Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(886)

Issue 6684051: Fix extra spacing in Kievan notation

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by aleksandr.andreev
Modified:
11 years, 6 months ago
Reviewers:
benko.pal, janek
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Fix extra spacing in Kievan notation In Kievan notation, notes should be spaced as tightly as possible within melismas. This patch fixes extra spacing caused by long syllables. Issue 2631.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M lily/include/paper-column.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/paper-column.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M lily/spacing-spanner.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6
aleksandr.andreev
Please review.
11 years, 6 months ago (2012-10-15 02:43:13 UTC) #1
benko.pal
I don't like that: the patch manipulates a staff based on note head. it also ...
11 years, 6 months ago (2012-10-15 20:00:28 UTC) #2
aleksandr.andreev
On 2012/10/15 20:00:28, benko.pal wrote: > I don't like that: the patch manipulates a staff ...
11 years, 6 months ago (2012-10-15 20:17:24 UTC) #3
benko.pal
> The presence of a long syllable in the lyrics makes the left_col->extent > larger ...
11 years, 6 months ago (2012-10-16 08:14:17 UTC) #4
aleksandr.andreev
On 2012/10/16 08:14:17, benko.pal wrote: > > The presence of a long syllable in the ...
11 years, 6 months ago (2012-10-16 20:06:11 UTC) #5
janek
11 years, 6 months ago (2012-10-21 16:06:34 UTC) #6
On Tue, Oct 16, 2012 at 10:06 PM,  <aleksandr.andreev@gmail.com> wrote:
> The GSoC issues do not deal with packed spacing, so this is somewhat
> different, though related. Do you have any ideas for how this issue
> could be addressed differently? Has there been any work on the various
> GSoC issues?

Yes, and it waits to be merged to master.  Unfortunately, some things
need considerable discussion before merging, and i'm very short on
time :(

best,
Janek
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b