Hello golang-dev@googlegroups.com (cc: sebastien.paolacci@gmail.com), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
11 years, 6 months ago
(2012-10-15 11:20:59 UTC)
#1
LGTM. I can't think I've never thought about that one, nor observed any crash (and ...
11 years, 6 months ago
(2012-10-15 18:59:15 UTC)
#4
LGTM. I can't think I've never thought about that one, nor observed
any crash (and I'm having long running processes..), but the deadlock
detection logic was definitely wrong by not expecting that the
scavenger could block (/unblock) other goroutines.
Thanks.
Sebastien
On Mon, Oct 15, 2012 at 1:22 PM, <dvyukov@google.com> wrote:
> I do not want to touch the deadlock detection logic, so I moved GC from
> the scavenger.
>
> https://codereview.appspot.com/6682050/
On 2012/10/15 18:59:15, Sebastien Paolacci wrote: > LGTM. I can't think I've never thought about ...
11 years, 6 months ago
(2012-10-16 10:41:18 UTC)
#5
On 2012/10/15 18:59:15, Sebastien Paolacci wrote:
> LGTM. I can't think I've never thought about that one, nor observed
> any crash (and I'm having long running processes..)
Probability of the crash is highly dependent on type of work you do. E.g. if you
have periodic GCs, then the scavenger won't trigger any GCs, I think that's your
case. If your program may not trigger GC for several minutes then the crash can
happen. If your program trigger GCs very episodically and you call ReadMemStats
frequently, then it will crash on a daily basis.
, but the deadlock
> detection logic was definitely wrong by not expecting that the
> scavenger could block (/unblock) other goroutines.
>
> Thanks.
>
> Sebastien
>
> On Mon, Oct 15, 2012 at 1:22 PM, <mailto:dvyukov@google.com> wrote:
> > I do not want to touch the deadlock detection logic, so I moved GC from
> > the scavenger.
> >
> > https://codereview.appspot.com/6682050/
Issue 6682050: code review 6682050: runtime: fix spurious deadlock crashes
(Closed)
Created 11 years, 6 months ago by dvyukov
Modified 11 years, 6 months ago
Reviewers:
Base URL:
Comments: 0