Issue 6679049: Fixed some warnings on GCC

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6679049: Fixed some warnings on GCC (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by jacek

Modified:
11 years, 6 months ago

Reviewers:
dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fixed some warnings on GCC Mozilla has recently made using NULL as integer an error (via -Werror=conversion-null GCC flag), which caused ANGLE to no longer compile on mingw in Mozilla tree. The ones that may not be obvious are removal of some <0 checks. They are not needed because they were done on unsigned types.

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -17 lines)			Patch
M	src/compiler/UnfoldShortCircuit.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/libEGL/Display.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/libGLESv2/Blit.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libGLESv2/Context.cpp	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/libGLESv2/ProgramBinary.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libGLESv2/Shader.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/libGLESv2/Texture.cpp	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/libGLESv2/utilities.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dgkoch

On 2012/10/15 12:20:12, jacek wrote: LGTM. I'll land it for you.

11 years, 6 months ago (2012-11-14 15:00:38 UTC) #2

dgkoch

Committed in r1393. Please close this review issue. http://code.google.com/p/angleproject/source/detail?r=1393

11 years, 6 months ago (2012-11-14 15:06:36 UTC) #3

jacek

11 years, 6 months ago (2012-11-16 09:41:00 UTC) #4

On 2012/11/14 15:06:36, dgkoch wrote:
> Committed in r1393.  Please close this review issue.
> http://code.google.com/p/angleproject/source/detail?r=1393

Thank you

Expand All Messages | Collapse All Messages