A few small comments, i'm probably not understanding something. https://codereview.appspot.com/6674043/diff/8001/src/pkg/net/tcpsock_plan9.go File src/pkg/net/tcpsock_plan9.go (right): https://codereview.appspot.com/6674043/diff/8001/src/pkg/net/tcpsock_plan9.go#newcode23 src/pkg/net/tcpsock_plan9.go:23: ...
11 years, 4 months ago
(2012-11-08 03:54:48 UTC)
#3
Mikio Hara <mikioh.mikioh@gmail.com> once said: > On Thu, Nov 8, 2012 at 12:37 PM, <ality@pbrane.org> ...
11 years, 4 months ago
(2012-11-08 12:39:11 UTC)
#7
Mikio Hara <mikioh.mikioh@gmail.com> once said:
> On Thu, Nov 8, 2012 at 12:37 PM, <ality@pbrane.org> wrote:
>
> > This shouldn't require knowledge of Plan 9 to review.
>
> Counter proposal: https://codereview.appspot.com/6814101/
I think this is probably the way to go.
I'll seperate out the os/user changes
into another CL and abandon this one.
Thanks,
Anthony
Hi, On Thu, Nov 8, 2012 at 9:39 PM, Anthony Martin <ality@pbrane.org> wrote: > I ...
11 years, 4 months ago
(2012-11-10 05:33:12 UTC)
#9
Hi,
On Thu, Nov 8, 2012 at 9:39 PM, Anthony Martin <ality@pbrane.org> wrote:
> I think this is probably the way to go.
I revised the counter proposal, splitting into two CLs
and changed consolidation approach to using embeds.
https://codereview.appspot.com/6821100/https://codereview.appspot.com/6820124/
> I'll seperate out the os/user changes
> into another CL and abandon this one.
I think the remaining part would be covered by this CL.
Hi Anthony, On 2012/11/12 21:46:17, rsc wrote: > I am not sure I understand the ...
11 years, 4 months ago
(2012-11-13 08:30:28 UTC)
#11
Hi Anthony,
On 2012/11/12 21:46:17, rsc wrote:
> I am not sure I understand the relationship between this CL and Mikio's. Has
> this CL been updated to remove the things that Mikio's CLs take care of?
I've submitted a CL that related to ipsock_plan9.go, so pls update, merge in
this CL.
Please move os/user/lookup stuff to its own CL. Looks very close, thank you. https://codereview.appspot.com/6674043/diff/17003/src/pkg/net/iprawsock_plan9.go File ...
11 years, 4 months ago
(2012-11-23 05:04:43 UTC)
#13
mikioh.mikioh@gmail.com once said: > LGTM I'll submit this once the builders get back to normal. ...
11 years, 4 months ago
(2012-11-27 01:14:02 UTC)
#16
mikioh.mikioh@gmail.com once said:
> LGTM
I'll submit this once the builders get back
to normal. A bunch of them are failing in
the net package for various reasons and I
don't want to muddy the waters.
Anthony
Issue 6674043: code review 6674043: net, os/user: update docs and sync API for Plan 9
(Closed)
Created 11 years, 5 months ago by ality
Modified 11 years, 4 months ago
Reviewers:
Base URL:
Comments: 15