Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(184)

Issue 6674043: code review 6674043: net, os/user: update docs and sync API for Plan 9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by ality
Modified:
11 years, 4 months ago
Reviewers:
CC:
golang-dev, dfc, mikio, bradfitz, rsc
Visibility:
Public.

Description

net: update docs and sync API for Plan 9

Patch Set 1 #

Patch Set 2 : diff -r cfa9208b98fc https://code.google.com/p/go/ #

Patch Set 3 : diff -r cfa9208b98fc https://code.google.com/p/go/ #

Patch Set 4 : diff -r e3d1b93bfa09 https://code.google.com/p/go/ #

Total comments: 10

Patch Set 5 : diff -r f2755950769b https://code.google.com/p/go/ #

Patch Set 6 : diff -r f2755950769b https://code.google.com/p/go/ #

Total comments: 5

Patch Set 7 : diff -r 026b89723112 https://code.google.com/p/go/ #

Patch Set 8 : diff -r 6aab0212379c https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -145 lines) Patch
M src/pkg/net/file_plan9.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/net/iprawsock_plan9.go View 1 2 3 4 5 6 1 chunk +2 lines, -62 lines 0 comments Download
M src/pkg/net/net.go View 1 2 3 4 2 chunks +12 lines, -0 lines 0 comments Download
M src/pkg/net/sock_posix.go View 1 2 3 4 2 chunks +0 lines, -12 lines 0 comments Download
M src/pkg/net/tcpsock_plan9.go View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/net/udpsock_plan9.go View 1 2 3 4 5 6 4 chunks +6 lines, -5 lines 0 comments Download
M src/pkg/net/unixsock_plan9.go View 1 2 3 4 5 6 2 chunks +3 lines, -62 lines 0 comments Download

Messages

Total messages: 17
ality
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
11 years, 5 months ago (2012-10-12 21:06:08 UTC) #1
ality
Gentle ping. This shouldn't require knowledge of Plan 9 to review. Thanks, Anthony
11 years, 4 months ago (2012-11-08 03:37:56 UTC) #2
dfc
A few small comments, i'm probably not understanding something. https://codereview.appspot.com/6674043/diff/8001/src/pkg/net/tcpsock_plan9.go File src/pkg/net/tcpsock_plan9.go (right): https://codereview.appspot.com/6674043/diff/8001/src/pkg/net/tcpsock_plan9.go#newcode23 src/pkg/net/tcpsock_plan9.go:23: ...
11 years, 4 months ago (2012-11-08 03:54:48 UTC) #3
ality
https://codereview.appspot.com/6674043/diff/8001/src/pkg/net/tcpsock_plan9.go File src/pkg/net/tcpsock_plan9.go (right): https://codereview.appspot.com/6674043/diff/8001/src/pkg/net/tcpsock_plan9.go#newcode23 src/pkg/net/tcpsock_plan9.go:23: } On 2012/11/08 03:54:48, dfc wrote: > Is this ...
11 years, 4 months ago (2012-11-08 04:34:43 UTC) #4
dfc
I don't think that plan9 is covered by the api tool, so you may have ...
11 years, 4 months ago (2012-11-08 04:36:34 UTC) #5
mikio
On Thu, Nov 8, 2012 at 12:37 PM, <ality@pbrane.org> wrote: > This shouldn't require knowledge ...
11 years, 4 months ago (2012-11-08 10:24:06 UTC) #6
ality
Mikio Hara <mikioh.mikioh@gmail.com> once said: > On Thu, Nov 8, 2012 at 12:37 PM, <ality@pbrane.org> ...
11 years, 4 months ago (2012-11-08 12:39:11 UTC) #7
bradfitz
https://codereview.appspot.com/6674043/diff/8001/src/pkg/net/ipsock_plan9.go File src/pkg/net/ipsock_plan9.go (right): https://codereview.appspot.com/6674043/diff/8001/src/pkg/net/ipsock_plan9.go#newcode311 src/pkg/net/ipsock_plan9.go:311: // Accept implements the Accept method in the Listener ...
11 years, 4 months ago (2012-11-08 18:17:30 UTC) #8
mikio
Hi, On Thu, Nov 8, 2012 at 9:39 PM, Anthony Martin <ality@pbrane.org> wrote: > I ...
11 years, 4 months ago (2012-11-10 05:33:12 UTC) #9
rsc
I am not sure I understand the relationship between this CL and Mikio's. Has this ...
11 years, 4 months ago (2012-11-12 21:46:17 UTC) #10
mikio
Hi Anthony, On 2012/11/12 21:46:17, rsc wrote: > I am not sure I understand the ...
11 years, 4 months ago (2012-11-13 08:30:28 UTC) #11
ality
Hello golang-dev@googlegroups.com, dave@cheney.net, mikioh.mikioh@gmail.com, bradfitz@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 4 months ago (2012-11-22 19:09:27 UTC) #12
mikio
Please move os/user/lookup stuff to its own CL. Looks very close, thank you. https://codereview.appspot.com/6674043/diff/17003/src/pkg/net/iprawsock_plan9.go File ...
11 years, 4 months ago (2012-11-23 05:04:43 UTC) #13
ality
https://codereview.appspot.com/6674043/diff/17003/src/pkg/net/iprawsock_plan9.go File src/pkg/net/iprawsock_plan9.go (right): https://codereview.appspot.com/6674043/diff/17003/src/pkg/net/iprawsock_plan9.go#newcode17 src/pkg/net/iprawsock_plan9.go:17: type IPConn struct{} On 2012/11/23 05:04:43, mikio wrote: > ...
11 years, 4 months ago (2012-11-26 18:11:14 UTC) #14
mikio
LGTM
11 years, 4 months ago (2012-11-27 00:54:54 UTC) #15
ality
mikioh.mikioh@gmail.com once said: > LGTM I'll submit this once the builders get back to normal. ...
11 years, 4 months ago (2012-11-27 01:14:02 UTC) #16
ality
11 years, 4 months ago (2012-11-30 19:42:01 UTC) #17
*** Submitted as https://code.google.com/p/go/source/detail?r=1b8c2fe167fc ***

net: update docs and sync API for Plan 9

R=golang-dev, dave, mikioh.mikioh, bradfitz, rsc
CC=golang-dev
https://codereview.appspot.com/6674043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b