Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4722)

Issue 6651053: This is the non-invasive version of the full Issue 2883 patch. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by dak
Modified:
11 years, 6 months ago
Reviewers:
janek
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

This is the non-invasive version of the full Issue 2883 patch. The sole difference is a different python/convertrules.py file, and a consequently much more confined conversion as the last commit. It does not show the full potential of the approach, obviously. Run scripts/auxiliar/update-with-convert-ly.sh Change \footnote user interface and behavior to match \hide/\omit etc. This does the following changes to the footnote user interface for footnotes in music rather than in markups: Time-based footnote syntax: \footnote [mark] offset #'Grob text \default -> \footnote [mark] offset text [ Context. ] Grob Like with any override, you now need to specify Context if it is not supposed to be Bottom, like with Staff.TimeSignature. Music-based footnote syntax: \footnote [mark] offset text music -> stays identical \footnote [mark] offset #'Grob text music -> \single\footnote [mark] offset text Grob music Specifying Context.Grob is possible, but Context gets ignored. Let \overrideProperty accept nested properties Change \tweak syntax to symbol syntax Instead of \tweak #'color, \tweak color is used. Instead of \tweak Accidental #'color, \tweak Accidental.color is used. convert-ly rule for \alterbroken, \accidentalStyle, \overrideProperty This is required since not all of the old call forms can be automatically recognized anymore, in particular not when the Scheme-only form #"Context.GrobName" is being used. Change \accidentalStyle to get a symbol list as argument This changes the syntax of \accidentalStyle to accept specs like Voice.piano-cautionary . Make \alterBroken, \hide, \omit, \overrideProperty, \shape take unquoted Context.Grob specs This changes the syntax of the named commands to accept Voice.Accidental and similar specifications without any quoting. Replace the rather fuzzy list-or-symbol? with symbol-list-or-symbol? list-or-symbol? was previously used in the meaning of symbol-list-or-symbol? only, and there is no point in not checking the list members for actually being symbols, in order to avoid ugly surprises later. Add symbol-list-or-music? predicate This is of interest for commands like \hide which accept either music (to see an override) or a grob specification like Accidental or Voice.Accidental. Allow the string "xxx.yyy" to parse as a symbol list This changes the parser to let xxx.yyy be a valid way of specifying a function argument required to be #'(xxx yyy). Allow property and grob paths to be constructed from strings Add symbol-list? predicate Allow LilyPond strings to stand in for symbols when parsing Bare words and quote-enclosed words meeting word syntax can now be used when a function argument expects to see a symbol. Let \accidentalStyle detect its optional context argument by looking at its letter case This is a fishy stopgap measure to let \accidentalStyle able to distinguish #'Voice "default" from "default" alone while we generate symbols from from #'Voice as well as "default". If the first letter is uppercase, the symbol is considered to be a context specification. Factor SCM_IDENTIFIER out from embedded_scm_arg* SCM_IDENTIFIER indicates "active Scheme" introduced with $ that is subject to copying and reinterpretation. While the parser had its own *_IDENTIFIER category for everything interpreted specially, the fallback SCM_IDENTIFIER itself never needed special or different treatment from material generated with # (SCM_TOKEN). As the various *_IDENTIFIER types are faded out, this is changing. As a consequence, SCM_IDENTIFIER no longer shares the non-terminals with other Scheme-type definitions. parser.yy: make is_regular_identifier match the lexer definition is_regular_identifier checks now for valid identifiers employing the definition of words that is also used in the lexer: letters, and characters outside of the ASCII range, interspersed with single - and _ characters. parser.yy: FRACTION does not require a closed expression before it FRACTION items can't trail any other valid expression without separating '*' or similar, so the argument list before them does not need to be of "closed" type. Assignments can't contain literal lyric music (wrong lexer mode) Since assignments can't happen in lyrics mode (only in INITIAL mode or the initial music mode), there is no point in supporting non-mode-switching items on the right side of assignments that can only occur in lyrics mode.

Patch Set 1 #

Patch Set 2 : Allow \override Accidental.color = #red (dot between grob spec and property path, \revert too) #

Patch Set 3 : Improve error messages, fix revert bug #

Patch Set 4 : Rebase on current mater #

Patch Set 5 : Fix \displayLilyMusic \tweak Accidental.color ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1350 lines, -939 lines) Patch
M Documentation/de/extending/programming-interface.itely View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/de/learning/tweaks.itely View 1 2 3 6 chunks +11 lines, -11 lines 0 comments Download
M Documentation/de/notation/changing-defaults.itely View 1 2 3 7 chunks +11 lines, -11 lines 0 comments Download
M Documentation/de/notation/input.itely View 1 2 3 4 chunks +14 lines, -14 lines 0 comments Download
M Documentation/de/notation/pitches.itely View 1 2 3 23 chunks +40 lines, -40 lines 0 comments Download
M Documentation/de/notation/spacing.itely View 1 2 3 5 chunks +14 lines, -14 lines 0 comments Download
M Documentation/es/extending/programming-interface.itely View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/es/learning/tweaks.itely View 1 2 3 6 chunks +12 lines, -12 lines 0 comments Download
M Documentation/es/notation/changing-defaults.itely View 1 2 3 7 chunks +11 lines, -11 lines 0 comments Download
M Documentation/es/notation/input.itely View 1 2 3 4 chunks +13 lines, -13 lines 0 comments Download
M Documentation/es/notation/pitches.itely View 1 2 3 24 chunks +41 lines, -41 lines 0 comments Download
M Documentation/es/notation/spacing.itely View 1 2 3 5 chunks +14 lines, -14 lines 0 comments Download
M Documentation/extending/programming-interface.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/fr/extending/programming-interface.itely View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/fr/learning/tweaks.itely View 1 2 3 6 chunks +12 lines, -12 lines 0 comments Download
M Documentation/fr/notation/changing-defaults.itely View 1 2 3 6 chunks +10 lines, -10 lines 0 comments Download
M Documentation/fr/notation/input.itely View 1 2 3 4 chunks +13 lines, -13 lines 0 comments Download
M Documentation/fr/notation/pitches.itely View 1 2 3 23 chunks +40 lines, -40 lines 0 comments Download
M Documentation/fr/notation/spacing.itely View 1 2 3 5 chunks +14 lines, -14 lines 0 comments Download
M Documentation/it/learning/tweaks.itely View 1 2 3 6 chunks +12 lines, -12 lines 0 comments Download
M Documentation/it/notation/pitches.itely View 1 2 3 23 chunks +40 lines, -40 lines 0 comments Download
M Documentation/ja/learning/tweaks.itely View 1 6 chunks +12 lines, -12 lines 0 comments Download
M Documentation/ja/notation/changing-defaults.itely View 1 7 chunks +11 lines, -11 lines 0 comments Download
M Documentation/ja/notation/input.itely View 1 4 chunks +13 lines, -13 lines 0 comments Download
M Documentation/ja/notation/pitches.itely View 1 23 chunks +40 lines, -40 lines 0 comments Download
M Documentation/ja/notation/spacing.itely View 1 5 chunks +14 lines, -14 lines 0 comments Download
M Documentation/learning/tweaks.itely View 1 6 chunks +12 lines, -12 lines 0 comments Download
M Documentation/ly-examples/bach-bwv610.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/notation/changing-defaults.itely View 1 7 chunks +11 lines, -11 lines 0 comments Download
M Documentation/notation/input.itely View 1 2 3 3 chunks +8 lines, -8 lines 0 comments Download
M Documentation/notation/pitches.itely View 1 23 chunks +40 lines, -40 lines 0 comments Download
M Documentation/notation/spacing.itely View 1 5 chunks +14 lines, -14 lines 0 comments Download
M Documentation/snippets/arabic-improvisation.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/chords-headword.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/new/chords-headword.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/new/score-for-diatonic-accordion.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/score-for-diatonic-accordion.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/text-headword.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/accidental-contemporary.ly View 1 2 chunks +5 lines, -5 lines 0 comments Download
M input/regression/accidental-piano.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/accidental-voice.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/alignment-vertical-manual-setting.ly View 1 2 chunks +4 lines, -4 lines 0 comments Download
M input/regression/alter-broken.ly View 1 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/display-lily-tests.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/footnote-auto-numbering.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/footnote-auto-numbering-page-reset.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/footnote-auto-numbering-vertical-order.ly View 1 4 chunks +4 lines, -4 lines 0 comments Download
M input/regression/footnote-break-visibility.ly View 1 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/footnote-spanner.ly View 1 3 chunks +7 lines, -7 lines 0 comments Download
M input/regression/grob-indirect-tweak.ly View 1 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/in-note.ly View 1 2 chunks +4 lines, -4 lines 0 comments Download
M input/regression/layout-from.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/mensural-ligatures.ly View 1 3 chunks +3 lines, -3 lines 0 comments Download
M input/regression/morgenlied.ly View 1 4 chunks +4 lines, -4 lines 0 comments Download
M input/regression/outside-staff-placement-directive.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/page-layout-manual-position.ly View 1 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/page-spacing.ly View 1 3 chunks +6 lines, -6 lines 0 comments Download
M input/regression/page-spacing-bass-figures.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/spacing-accidental-stretch.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/typography-demo.ly View 1 4 chunks +4 lines, -4 lines 0 comments Download
M lily/footnote-engraver.cc View 2 chunks +2 lines, -41 lines 0 comments Download
M lily/parser.yy View 1 2 27 chunks +592 lines, -183 lines 0 comments Download
M ly/bagpipe.ly View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ly/engraver-init.ly View 1 3 chunks +2 lines, -3 lines 0 comments Download
M ly/music-functions-init.ly View 1 2 3 4 11 chunks +88 lines, -103 lines 0 comments Download
M ly/property-init.ly View 1 2 chunks +14 lines, -11 lines 0 comments Download
M python/convertrules.py View 1 2 3 1 chunk +43 lines, -0 lines 0 comments Download
M scm/c++.scm View 2 chunks +12 lines, -2 lines 0 comments Download
M scm/display-lily.scm View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M scm/lily.scm View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 1
janek
11 years, 6 months ago (2012-10-24 09:13:46 UTC) #1
the description LGTM (i.e. i'm ok with what you say this patch does).
I'm sorry that i don't give any feedback on the actual code, but it's about a
thousand lines of changes and i don't have time to read them :(

Janek
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b