Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(875)

Issue 6642043: code review 6642043: pprof: filter out runtime.settype and fix --svg mode to... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by bradfitz
Modified:
11 years, 5 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

pprof: filter out runtime.settype and fix --svg mode to produce valid XML

Patch Set 1 #

Patch Set 2 : diff -r 1c5c3c6b15bc https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1c5c3c6b15bc https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r ff0701405048 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M misc/pprof View 1 2 3 5 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 3
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 5 months ago (2012-10-08 18:16:13 UTC) #1
rsc
LGTM
11 years, 5 months ago (2012-10-09 13:46:07 UTC) #2
bradfitz
11 years, 5 months ago (2012-10-16 03:49:20 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=b595997205c8 ***

pprof: filter out runtime.settype and fix --svg mode to produce valid XML

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6642043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b