Issue 6637060: code review 6637060: runtime/debug: fix the test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6637060: code review 6637060: runtime/debug: fix the test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by dvyukov

Modified:
11 years, 6 months ago

Reviewers:

CC:
golang-dev, minux1

Visibility:
Public.

Description

runtime/debug: fix the test If source are not available, then the stack looks like: stack_test.go:40: /tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/runtime/debug/bla-bla-bla/src/pkg/runtime/debug/stack_test.go:15 (0x43fb11) stack_test.go:40: /tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/runtime/debug/bla-bla-bla/src/pkg/runtime/debug/stack_test.go:18 (0x43fb7a) stack_test.go:40: /tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/runtime/debug/bla-bla-bla/src/pkg/runtime/debug/stack_test.go:37 (0x43fbf4) stack_test.go:40: /tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/testing/bla-bla-bla/src/pkg/testing/testing.go:301 (0x43b5ba) stack_test.go:40: /tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/runtime/bla-bla-bla/src/pkg/runtime/proc.c:276 (0x410670) stack_test.go:40: which is 6 lines.

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/runtime/debug/stack_test.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

11 years, 6 months ago (2012-10-10 15:42:45 UTC) #1

minux1

the change LGTM. PS: I wonder why this occurs (can't find source code) in run.bash, ...

11 years, 6 months ago (2012-10-10 16:34:49 UTC) #2

dvyukov

On 2012/10/10 16:34:49, minux wrote: > the change LGTM. > > PS: I wonder why ...

11 years, 6 months ago (2012-10-10 16:48:25 UTC) #3

dvyukov

11 years, 6 months ago (2012-10-10 16:49:55 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=236ee151d1bc ***

runtime/debug: fix the test
If source are not available, then the stack looks like:
stack_test.go:40:
	/tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/runtime/debug/bla-bla-bla/src/pkg/runtime/debug/stack_test.go:15
(0x43fb11)
stack_test.go:40:
	/tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/runtime/debug/bla-bla-bla/src/pkg/runtime/debug/stack_test.go:18
(0x43fb7a)
stack_test.go:40:
	/tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/runtime/debug/bla-bla-bla/src/pkg/runtime/debug/stack_test.go:37
(0x43fbf4)
stack_test.go:40:
	/tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/testing/bla-bla-bla/src/pkg/testing/testing.go:301
(0x43b5ba)
stack_test.go:40:
	/tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/runtime/bla-bla-bla/src/pkg/runtime/proc.c:276
(0x410670)
stack_test.go:40:
which is 6 lines.

R=golang-dev, minux.ma
CC=golang-dev
http://codereview.appspot.com/6637060

Expand All Messages | Collapse All Messages