Issue 6625072: code review 6625072: ld: add -B option to set build ID

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6625072: code review 6625072: ld: add -B option to set build ID (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by iant

Modified:
11 years, 6 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

cmd/ld: add -B option to set build ID Background on build ID: http://fedoraproject.org/wiki/RolandMcGrath/BuildID

Patch Set 1 #

Patch Set 2 : diff -r 06308c9edb43 https://go.googlecode.com/hg/ #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+167 lines, -15 lines)			Patch
M	src/cmd/5l/asm.c	View	7 chunks	+25 lines, -5 lines	0 comments	Download
M	src/cmd/5l/obj.c	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/cmd/6l/asm.c	View	7 chunks	+25 lines, -5 lines	0 comments	Download
M	src/cmd/6l/obj.c	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/cmd/8l/asm.c	View	7 chunks	+25 lines, -5 lines	0 comments	Download
M	src/cmd/8l/obj.c	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/cmd/ld/doc.go	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/cmd/ld/elf.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/cmd/ld/elf.c	View	2 chunks	+73 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 6 months ago (2012-10-09 22:03:49 UTC) #1

iant

11 years, 6 months ago (2012-10-09 22:29:54 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=1b587887ceb2 ***

cmd/ld: add -B option to set build ID

Background on build ID:
http://fedoraproject.org/wiki/RolandMcGrath/BuildID

R=rsc
CC=golang-dev
http://codereview.appspot.com/6625072

Expand All Messages | Collapse All Messages