Issue 6623052: code review 6623052: image/jpeg: clean up BenchmarkDecode and BenchmarkEncod...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6623052: code review 6623052: image/jpeg: clean up BenchmarkDecode and BenchmarkEncod... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by nigeltao

Modified:
11 years, 6 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

image/jpeg: clean up BenchmarkDecode and BenchmarkEncode to not refer to opacity. Those references were copy/pasted from the image/png encoding benchmarks, which cares whether or not the source image is opaque, but the JPEG encoder does not care.

Patch Set 1 #

Patch Set 2 : diff -r b32301e11025 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b32301e11025 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 696fa4935eed https://go.googlecode.com/hg/ #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -8 lines)			Patch
	M	src/pkg/image/jpeg/writer_test.go	View	1	2 chunks	+5 lines, -8 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 6 months ago (2012-10-07 00:19:03 UTC) #1

nigeltao

11 years, 6 months ago (2012-10-07 00:30:54 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=0df32a68533e ***

image/jpeg: clean up BenchmarkDecode and BenchmarkEncode to not
refer to opacity. Those references were copy/pasted from the
image/png encoding benchmarks, which cares whether or not the
source image is opaque, but the JPEG encoder does not care.

R=r
CC=golang-dev
http://codereview.appspot.com/6623052

Expand All Messages | Collapse All Messages