Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2019)

Issue 6618055: code review 6618055: exp/html: update package docs; a node's children is a linked (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by nigeltao
Modified:
11 years, 6 months ago
Reviewers:
CC:
r, minux1, golang-dev
Visibility:
Public.

Description

exp/html: update package docs and add an example; a node's children is a linked list, not a slice.

Patch Set 1 #

Patch Set 2 : diff -r 7b037816cd5c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7b037816cd5c https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 7b037816cd5c https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 7b037816cd5c https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 6 : diff -r 5749e60d2b6b https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -1 line) Patch
M src/pkg/exp/html/doc.go View 1 1 chunk +1 line, -1 line 0 comments Download
A src/pkg/exp/html/example_test.go View 1 2 3 4 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 7
nigeltao
Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 6 months ago (2012-10-07 08:55:02 UTC) #1
minux1
Can you (also?) make that code snippet an Example function so that compiler can check ...
11 years, 6 months ago (2012-10-07 08:57:26 UTC) #2
nigeltao
On 7 October 2012 19:57, <minux.ma@gmail.com> wrote: > Can you (also?) make that code snippet ...
11 years, 6 months ago (2012-10-07 09:55:58 UTC) #3
minux1
LGTM.
11 years, 6 months ago (2012-10-07 10:01:14 UTC) #4
r
http://codereview.appspot.com/6618055/diff/9001/src/pkg/exp/html/example_test.go File src/pkg/exp/html/example_test.go (right): http://codereview.appspot.com/6618055/diff/9001/src/pkg/exp/html/example_test.go#newcode5 src/pkg/exp/html/example_test.go:5: // This example demonstrates parsing HTML data and walking ...
11 years, 6 months ago (2012-10-07 12:33:26 UTC) #5
nigeltao
https://codereview.appspot.com/6618055/diff/9001/src/pkg/exp/html/example_test.go File src/pkg/exp/html/example_test.go (right): https://codereview.appspot.com/6618055/diff/9001/src/pkg/exp/html/example_test.go#newcode5 src/pkg/exp/html/example_test.go:5: // This example demonstrates parsing HTML data and walking ...
11 years, 6 months ago (2012-10-12 08:32:56 UTC) #6
nigeltao
11 years, 6 months ago (2012-10-17 23:26:00 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=9b2c48c9d597 ***

exp/html: update package docs and add an example; a node's children is
a linked list, not a slice.

R=r, minux.ma
CC=golang-dev
http://codereview.appspot.com/6618055
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b