Issue 6613069: code review 6613069: testing: fix extra tabs when t.Log("string")

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6613069: code review 6613069: testing: fix extra tabs when t.Log("string") (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by minux1

Modified:
11 years, 6 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

testing: fix extra tabs when t.Log("string") t.Log("line 1\nline 2\nline 3") Old output: === RUN TestLine3 --- PASS: TestLine3 (0.00 seconds) testing_test.go:25: line 1 line 2 line 3 PASS New output: === RUN TestLine3 --- PASS: TestLine3 (0.00 seconds) testing_test.go:24: line 1 line 2 line 3 PASS

Patch Set 1 #

Patch Set 2 : diff -r 7b037816cd5c https://code.google.com/p/go/ #

Patch Set 3 : diff -r 986908b3e4ae https://code.google.com/p/go/ #

Patch Set 4 : diff -r abd56df63b8f https://code.google.com/p/go/ #

Patch Set 5 : diff -r abd56df63b8f https://code.google.com/p/go/ #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	src/pkg/testing/testing.go	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 6 months ago (2012-10-07 15:51:18 UTC) #1

minux1

11 years, 6 months ago (2012-10-07 16:22:08 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=cdb83cb72d03 ***

testing: fix extra tabs when t.Log("string")

t.Log("line 1\nline 2\nline 3")

Old output:
=== RUN TestLine3
--- PASS: TestLine3 (0.00 seconds)
testing_test.go:25: 	line 1
		line 2
		line 3
		PASS

New output:
=== RUN TestLine3
--- PASS: TestLine3 (0.00 seconds)
testing_test.go:24: 	line 1
		line 2
		line 3
PASS

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6613069

Expand All Messages | Collapse All Messages