Issue 6596046: fixing issue 292 (X and not X matching everything)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6596046: fixing issue 292 (X and not X matching everything) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by Thomas.J.Waldmann

Modified:
11 years, 2 months ago

Reviewers:
thomas.j.waldmann, Reimar Bauer

Visibility:
Public.

Patch Set 1 #

Total comments: 11

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -20 lines)			Patch
	M	src/whoosh/query/nary.py	View		7 chunks	+43 lines, -20 lines	11 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ThomasJWaldmann

http://codereview.appspot.com/6596046/diff/1/src/whoosh/query/nary.py File src/whoosh/query/nary.py (right): http://codereview.appspot.com/6596046/diff/1/src/whoosh/query/nary.py#newcode190 src/whoosh/query/nary.py:190: return q we can short-circuit this for AND, but ...

11 years, 6 months ago (2012-09-30 22:15:44 UTC) #1

Reimar Bauer

some small comments http://codereview.appspot.com/6596046/diff/1/src/whoosh/query/nary.py File src/whoosh/query/nary.py (right): http://codereview.appspot.com/6596046/diff/1/src/whoosh/query/nary.py#newcode210 src/whoosh/query/nary.py:210: # is_and_like == True if the ...

11 years, 6 months ago (2012-09-30 22:29:11 UTC) #2

ThomasJWaldmann

11 years, 6 months ago (2012-09-30 22:35:53 UTC) #3

http://codereview.appspot.com/6596046/diff/1/src/whoosh/query/nary.py
File src/whoosh/query/nary.py (right):

http://codereview.appspot.com/6596046/diff/1/src/whoosh/query/nary.py#newcode210
src/whoosh/query/nary.py:210: # is_and_like == True if the query is like an AND,
False if like OR
before this patch, it only worked for the AND case and misbhehaved for OR, see
the unit tests in my pull request.

http://codereview.appspot.com/6596046/diff/1/src/whoosh/query/nary.py#newcode229
src/whoosh/query/nary.py:229: # A and B and not C and not D = (A and B) andnot
(C or D)
On 2012/09/30 22:29:11, Reimar Bauer wrote:
> and not

whoosh has a AndNot() term, see below, thus i left out the blank intentionally

Expand All Messages | Collapse All Messages