Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4927)

Issue 6590047: code review 6590047: pkg/syscall: Plan 9, 64-bit: Update error checks from s... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by akumar
Modified:
11 years, 6 months ago
Reviewers:
CC:
rsc, r, golang-dev
Visibility:
Public.

Description

pkg/syscall: Plan 9, 64-bit: Update error checks from sys calls. This change updates CL 6576057 for exceptional cases where return values from Syscall/RawSyscall functions are used. The system calls return 32-bit integers. With the recent change in size of `int' in Go for amd64, the type conversion was not catching `-1' return values. This change makes the conversion explicitly `int32'.

Patch Set 1 #

Patch Set 2 : diff -r f4a92d7eeb8d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f4a92d7eeb8d https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M src/pkg/syscall/exec_plan9.go View 1 9 chunks +10 lines, -10 lines 0 comments Download
M src/pkg/syscall/syscall_plan9.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
akumar
Hello rsc@golang.org, r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 6 months ago (2012-09-30 21:31:48 UTC) #1
r
LGTM
11 years, 6 months ago (2012-10-01 00:06:30 UTC) #2
r
11 years, 6 months ago (2012-10-01 00:09:26 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=03190651924e ***

pkg/syscall: Plan 9, 64-bit: Update error checks from sys calls.

This change updates CL 6576057 for exceptional cases where
return values from Syscall/RawSyscall functions are used.

The system calls return 32-bit integers. With the recent change
in size of `int' in Go for amd64, the type conversion was not
catching `-1' return values. This change makes the conversion
explicitly `int32'.

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/6590047

Committer: Rob Pike <r@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b