Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1513)

Issue 6584073: lilypond-book: treat iffalse sections in latex as block comments (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by Reinhold
Modified:
8 years, 1 month ago
Reviewers:
janek, wl, reinhold, lemzwerg, dak, Julien Rioux
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

lilypond-book: treat iffalse sections in latex as block comments

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
A input/regression/lilypond-book/tex-multiline-comments.lytex View 1 chunk +14 lines, -0 lines 0 comments Download
M python/book_latex.py View 1 chunk +6 lines, -0 lines 3 comments Download

Messages

Total messages: 6
janek
Hmm. Somehow the commit message doesn't seem self-explanatory enough to me, but i fail to ...
11 years, 5 months ago (2012-10-05 14:50:27 UTC) #1
Julien Rioux
Try to add a regression test example with a valid lilypond block inbetween two multiline ...
11 years, 5 months ago (2012-10-06 02:12:41 UTC) #2
lemzwerg
http://codereview.appspot.com/6584073/diff/1/python/book_latex.py File python/book_latex.py (right): http://codereview.appspot.com/6584073/diff/1/python/book_latex.py#newcode88 python/book_latex.py:88: \\iffalse.*\\fi))''', On 2012/10/06 02:12:41, Julien Rioux wrote: > .* ...
11 years, 5 months ago (2012-10-06 04:33:26 UTC) #3
reinhold_fam.tuwien.ac.at
On 2012-10-06 06:33, lemzwerg@googlemail.com wrote: > > http://codereview.appspot.com/6584073/diff/1/python/book_latex.py > File python/book_latex.py (right): > > http://codereview.appspot.com/6584073/diff/1/python/book_latex.py#newcode88 ...
11 years, 5 months ago (2012-10-06 12:05:42 UTC) #4
dak
Reinhold Kainhofer <reinhold@fam.tuwien.ac.at> writes: > On 2012-10-06 06:33, lemzwerg@googlemail.com wrote: > >> http://codereview.appspot.com/6584073/diff/1/python/book_latex.py#newcode88 >> python/book_latex.py:88: ...
11 years, 5 months ago (2012-10-06 12:59:00 UTC) #5
wl_gnu.org
11 years, 5 months ago (2012-10-06 17:59:29 UTC) #6
> So, your opinion is that lilypond-book SHOULD process the
> \lilypond{...} code inside the \iffalse section and spectacularly
> fail.

It is debatable how much plain TeX code should be used at all in a
LaTeX document.  Just think of a latex->html translation.

> With my colleagues, I have never seen \begin{comment} for comments,
> all the researchers I have worked with so far were using \iffalse.

OK.

> So, I will add \begin{comment} to the pattern, too,

Thanks.

> but I still think that lilypond-book SHOULD ignore everything inside
> \iffalse.

OK.


    Werner
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b