Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1536)

Issue 6575048: Issue 2859: Provide \hide and \omit functions for transparent and void glyphs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by dak
Modified:
11 years, 6 months ago
Reviewers:
Keith, janek, wl, pounderd, Graham Percival, pkx166h, pacovila
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Issue 2859: Provide \hide and \omit functions for transparent and void glyphs Both functions take either a grob name to override, or a music expression to tweak (that is, the type of the argument decides whether this results in an override or a tweak). \hide sets #'transparent for the affected grob to ##t, \omit sets #'stencil for the affected grob to ##f. Example uses are \new Voice \with { \omit StringNumber } { c'\4 } { <c' \hide g'~> g' } Also: Add string-or-music? predicate

Patch Set 1 #

Patch Set 2 : Change \omit to \no #

Patch Set 3 : Sort \no before \noPageBreak #

Total comments: 1

Patch Set 4 : Change \no back to \omit again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M ly/music-functions-init.ly View 1 2 3 2 chunks +24 lines, -0 lines 0 comments Download
M scm/c++.scm View 1 chunk +3 lines, -0 lines 0 comments Download
M scm/lily.scm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 28
janek
sorry to join the discussion so late... what about using \no for turning stencil off? ...
11 years, 7 months ago (2012-09-28 05:18:42 UTC) #1
dak
On 2012/09/28 05:18:42, janek wrote: > sorry to join the discussion so late... > > ...
11 years, 7 months ago (2012-09-28 05:33:10 UTC) #2
janek
On Fri, Sep 28, 2012 at 7:33 AM, <dak@gnu.org> wrote: >> what about using \no ...
11 years, 7 months ago (2012-09-28 06:26:03 UTC) #3
dak
On 2012/09/28 06:26:03, janek wrote: > On Fri, Sep 28, 2012 at 7:33 AM, <mailto:dak@gnu.org> ...
11 years, 7 months ago (2012-09-28 07:30:59 UTC) #4
janek
On Fri, Sep 28, 2012 at 9:30 AM, <dak@gnu.org> wrote: > I must be in ...
11 years, 7 months ago (2012-09-28 15:06:38 UTC) #5
dak
On 2012/09/28 15:06:38, janek wrote: > On Fri, Sep 28, 2012 at 9:30 AM, <mailto:dak@gnu.org> ...
11 years, 7 months ago (2012-09-28 15:40:31 UTC) #6
wl_gnu.org
> The only drawback is that one might want \yes/\no as a pairing for some ...
11 years, 7 months ago (2012-09-28 19:13:19 UTC) #7
janek
Too bad that \delete is taken... Maybe using \no is the right choice, although i'd ...
11 years, 7 months ago (2012-09-29 16:44:36 UTC) #8
Graham Percival
https://codereview.appspot.com/6575048/diff/8001/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/6575048/diff/8001/ly/music-functions-init.ly#newcode649 ly/music-functions-init.ly:649: no = why not use "omit" instead of "no" ...
11 years, 7 months ago (2012-10-02 00:23:55 UTC) #9
dak
On 2012/10/02 00:23:55, Graham Percival wrote: > https://codereview.appspot.com/6575048/diff/8001/ly/music-functions-init.ly > File ly/music-functions-init.ly (right): > > https://codereview.appspot.com/6575048/diff/8001/ly/music-functions-init.ly#newcode649 ...
11 years, 7 months ago (2012-10-02 03:38:42 UTC) #10
dak
On 2012/10/02 03:38:42, dak wrote: > On 2012/10/02 00:23:55, Graham Percival wrote: > > https://codereview.appspot.com/6575048/diff/8001/ly/music-functions-init.ly ...
11 years, 7 months ago (2012-10-02 09:15:22 UTC) #11
Keith
Still looks good. \omit is better than \no because 'omit' is a verb like we ...
11 years, 7 months ago (2012-10-02 11:01:52 UTC) #12
dak
On 2012/10/02 11:01:52, Keith wrote: > Still looks good. What does still look good? > ...
11 years, 7 months ago (2012-10-02 11:42:59 UTC) #13
pkx166h
I know \remove has been taken, but is it possible to make a function (?) ...
11 years, 7 months ago (2012-10-02 11:50:04 UTC) #14
dak
On 2012/10/02 11:50:04, J_lowe wrote: > I know \remove has been taken, but is it ...
11 years, 7 months ago (2012-10-02 12:18:29 UTC) #15
janek
@James: good question about \remove. @David: the example you gave helped me understand why the ...
11 years, 7 months ago (2012-10-02 21:07:50 UTC) #16
Keith
On Tue, 02 Oct 2012 04:42:59 -0700, <dak@gnu.org> wrote: > On 2012/10/02 11:01:52, Keith wrote: ...
11 years, 7 months ago (2012-10-03 04:04:07 UTC) #17
dak
On 2012/10/03 04:04:07, Keith wrote: > If you name it '\hide', I'll probably make an ...
11 years, 7 months ago (2012-10-03 06:15:23 UTC) #18
janek
On Wed, Oct 3, 2012 at 8:15 AM, <dak@gnu.org> wrote: > Given existing naming choices, ...
11 years, 7 months ago (2012-10-03 06:25:54 UTC) #19
Keith
On Tue, 02 Oct 2012 23:15:23 -0700, <dak@gnu.org> wrote: > \hide and \no are for ...
11 years, 7 months ago (2012-10-03 06:27:56 UTC) #20
dak
On 2012/10/03 06:27:56, Keith wrote: > On Tue, 02 Oct 2012 23:15:23 -0700, <mailto:dak@gnu.org> wrote: ...
11 years, 7 months ago (2012-10-03 08:25:30 UTC) #21
pacovila
2012/10/2 <k-ohara5a5a@oco.net>: > No is used in several senses in English. Here it serves as ...
11 years, 7 months ago (2012-10-03 10:39:10 UTC) #22
dak
Francisco Vila <paconet.org@gmail.com> writes: > 2012/10/2 <k-ohara5a5a@oco.net>: >> No is used in several senses in ...
11 years, 7 months ago (2012-10-03 10:45:35 UTC) #23
janek
On Wed, Oct 3, 2012 at 12:45 PM, David Kastrup <dak@gnu.org> wrote: > incompatible with ...
11 years, 7 months ago (2012-10-03 13:31:33 UTC) #24
dak
Janek Warchoł <janek.lilypond@gmail.com> writes: > On Wed, Oct 3, 2012 at 12:45 PM, David Kastrup ...
11 years, 7 months ago (2012-10-03 14:04:52 UTC) #25
pounderd_lineone.net
>----Original Message---- >From: dak@gnu.org >Date: 03/10/2012 15:04 >To: "Janek Warchoł"<janek.lilypond@gmail.com> >Cc: <k-ohara5a5a@oco.net>, <reply@codereview-hr.appspotmail.com>, <lilypond-devel@gnu.org> >Subj: ...
11 years, 7 months ago (2012-10-03 19:32:15 UTC) #26
dak
On 2012/10/03 19:32:15, pounderd_lineone.net wrote: > > >----Original Message---- > >From: mailto:dak@gnu.org > >Call me ...
11 years, 7 months ago (2012-10-03 20:05:59 UTC) #27
janek
11 years, 6 months ago (2012-10-04 15:37:23 UTC) #28
On Wed, Oct 3, 2012 at 10:05 PM,  <dak@gnu.org> wrote:
>
> Here are a few other suggestions:
>   120 Moby Thesaurus words for "annihilate": [...]

Let's call it \slay.  After that we only need to create a Dragon grob
and we'll have a fairy-tale.

;)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b